From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932523AbdLTK3Q (ORCPT <rfc822;w@1wt.eu>);
        Wed, 20 Dec 2017 05:29:16 -0500
Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:49850 "EHLO
        foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932133AbdLTK3M (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 20 Dec 2017 05:29:12 -0500
Date: Wed, 20 Dec 2017 10:29:55 +0000
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Keerthy <j-keerthy@ti.com>
Cc: Vignesh R <vigneshr@ti.com>, Bjorn Helgaas <bhelgaas@google.com>,
        Kishon Vijay Abraham I <kishon@ti.com>, linux-omap@vger.kernel.org,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci: dwc: pci-dra7xx: Make shutdown handler static
Message-ID: <20171220102955.GA941@red-moon>
References: <20171201050652.13998-1-vigneshr@ti.com>
 <12f94b3d-5192-d53a-8390-812fe9b7b229@ti.com>
 <20171201165314.GB29985@red-moon>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171201165314.GB29985@red-moon>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 01, 2017 at 04:53:14PM +0000, Lorenzo Pieralisi wrote:
> On Fri, Dec 01, 2017 at 10:43:53AM +0530, Keerthy wrote:
> > 
> > 
> > On Friday 01 December 2017 10:36 AM, Vignesh R wrote:
> > > Declare dra7xx_pcie_shutdown() as a static function as its not used
> > > elsewhere.
> > 
> > Seems like the below version that had static version was not taken:
> > 
> > https://patchwork.kernel.org/patch/10052579/
> 
> It looks like I can drop the patch above then - let me know if
> that's ok.

I would appreciate some feedback; I assume that dropping the patch above
and applying the patch in $SUBJECT is what you expect, if there is a
problem with that please manifest yourselves.

Lorenzo

> Thanks,
> Lorenzo
> 
> > So for this patch:
> > 
> > Reviewed-by: Keerthy <j-keerthy@ti.com>
> > 
> > > 
> > > Signed-off-by: Vignesh R <vigneshr@ti.com>
> > > ---
> > >  drivers/pci/dwc/pci-dra7xx.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> > > index 59e8de34cec6..b9db442af793 100644
> > > --- a/drivers/pci/dwc/pci-dra7xx.c
> > > +++ b/drivers/pci/dwc/pci-dra7xx.c
> > > @@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
> > >  }
> > >  #endif
> > >  
> > > -void dra7xx_pcie_shutdown(struct platform_device *pdev)
> > > +static void dra7xx_pcie_shutdown(struct platform_device *pdev)
> > >  {
> > >  	struct device *dev = &pdev->dev;
> > >  	struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
> > >