From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752766AbdLUPOd (ORCPT ); Thu, 21 Dec 2017 10:14:33 -0500 Received: from mx2.suse.de ([195.135.220.15]:33837 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751600AbdLUPOa (ORCPT ); Thu, 21 Dec 2017 10:14:30 -0500 Date: Thu, 21 Dec 2017 16:14:28 +0100 From: Petr Mladek To: Miroslav Benes Cc: jpoimboe@redhat.com, jeyu@kernel.org, jikos@kernel.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, jbaron@akamai.com Subject: Re: [PATCH 2/2] livepatch: Allow loading modules on architectures without HAVE_RELIABLE_STACKTRACE Message-ID: <20171221151428.rt4dlizxb5nqhb3h@pathway.suse.cz> References: <20171208172523.12150-1-mbenes@suse.cz> <20171208172523.12150-3-mbenes@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171208172523.12150-3-mbenes@suse.cz> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 2017-12-08 18:25:23, Miroslav Benes wrote: > Now that immediate feature was removed, it is not possible to load > livepatch modules on architectures without HAVE_RELIABLE_STACKTRACE. Fix > it by removing guilty check in klp_register_patch(). > > The architectures without HAVE_RELIABLE_STACKTRACE will now rely only on > kernelspace/userspace boundary switching, the (fake) signal and force > feature. I do not thing that this is a good idea. It encourages people to use the force feature. They might get used to it. If people are going to provide livepatches, they should be capable enough to provide a kernel where it is allowed. IMHO, the upstream kernel should not support bad/dirty practices out of box. Best Regards, Petr