From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753669AbdLUQPt (ORCPT ); Thu, 21 Dec 2017 11:15:49 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:55467 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751717AbdLUQPs (ORCPT ); Thu, 21 Dec 2017 11:15:48 -0500 From: Arnd Bergmann To: Hans de Goede , Arnd Bergmann , Greg Kroah-Hartman Cc: Joe Perches , Larry Finger , linux-kernel@vger.kernel.org Subject: [PATCH v2] virt: vbox: use %pap format for printing resource_size_t Date: Thu, 21 Dec 2017 17:15:18 +0100 Message-Id: <20171221161529.3462263-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:rkd7jL0TIePuJH+c35L9fn4bUe2hbV9OMCoBPy/L/Ifemo26sYW dFsOUr+EDcWMI8nvDa5Hpelu/kEqKwLnnAewEl4q7zn65f0elB2eC7xd5qwZpRztZ4HPWi9 ZsKry+HEUiY17QWiujQiscS6fvUoyL53H0h3Bh3Sa4gRan/W6ws0qBq1i+KP9Apa3EQuLxS VoG6aqRkRFoP+VXTJY2+w== X-UI-Out-Filterresults: notjunk:1;V01:K0:q9b/orzeFuM=:Hn8NiCJtkGeBFFsWGkri/h sIVgApcwrbohaA7944nN6Pz31As/PmssE1geOi2wzbiGmwb44KtOYYWGUyovpk3XNv4pR9u64 k3nXxlAZ5dOhBlx+x3fqG2BADc2IPHJOeebGx2rq/ssJ0YkiMlyPktuUgul4gvvRqlWGU/rRm ccBmeKYjZYjfpxFjOsGYt3Vly+f2j4/vh5bxzPBs/8VOepSwVqg3reQiYeIGRaZl/Z5K1zo4u MNf1LIpNp2BLHU4JOnRUDjGBXugTpb2yJv7oSBxnyzfUfWVLzp8gCLa2SKgN7CSiX4kGeiD+9 UGRAZDMAuLW+ibQjIedoUQfqzN3BivI3WLsydSBVY2yGc2s+aeVCtf5YJvR3OmFnDVYHG21J7 4zCNKqrD/MeKdsGQKbPFkPkMmpsU76MKfU3CqqBtqtLfr4nWwFc+XdMmSDo3zkDFO3jYBdwS2 Bl71/zOGTq0q3qZcIdo5YAVGUd/u62adHOYiPUb9FDCKpoQeGks2Jv75/mwCbNOOW2zu/5tVd Gtx5e/gW7gFuGXSETPQzWjP+jnsy08b+2eV31l0HzDa1Df07fwwwlJh4HuKJO2eSsUfcf7pXq Iq7a5OueqwYigyn8mdesFgby8tZ0oQ18GYokxF3ry6gbLvYD8l7aIfGZXA38dttvD8kbHjC3z 5Kpc7uK/CRblBlja3p+GpGHRETONw9CG6+jlMP6VGF/VcWfdiOSnH9eADWCFt1EX2nkpdCBBc CbifJo209I3/kdZMIeDWF29S2FkF4F3Q2l26TQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org resource_size_t may be larger than pointers depending on configuration, so we can run into this build warning: drivers/virt/vboxguest/vboxguest_linux.c: In function 'vbg_pci_probe': drivers/virt/vboxguest/vboxguest_linux.c:295:4: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] drivers/virt/vboxguest/vboxguest_linux.c:367:4: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] This uses the special %pap to print the address by reference. Fixes: 0ba002bc4393 ("virt: Add vboxguest driver for Virtual Box Guest integration") Signed-off-by: Arnd Bergmann --- v2: Use %pap instead of the %rR that was just as incorrect, as pointed out by Joe Perches. --- drivers/virt/vboxguest/vboxguest_linux.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c index d045aa51ce03..82e280d38cc2 100644 --- a/drivers/virt/vboxguest/vboxguest_linux.c +++ b/drivers/virt/vboxguest/vboxguest_linux.c @@ -291,8 +291,8 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id) vmmdev = devm_ioremap(dev, mmio, mmio_len); if (!vmmdev) { - vbg_err("vboxguest: Error ioremap failed; MMIO addr=%p size=%d\n", - (void *)mmio, (int)mmio_len); + vbg_err("vboxguest: Error ioremap failed; MMIO addr=%pap size=%pap\n", + &mmio, &mmio_len); goto err_disable_pcidev; } @@ -362,9 +362,9 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id) device_create_file(dev, &dev_attr_host_version); device_create_file(dev, &dev_attr_host_features); - vbg_info("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %p (size %d)\n", + vbg_info("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %pap (size %pap)\n", gdev->misc_device.minor, pci->irq, gdev->io_port, - (void *)mmio, (int)mmio_len); + &mmio, &mmio_len); return 0; -- 2.9.0