From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755767AbdLUV3r (ORCPT ); Thu, 21 Dec 2017 16:29:47 -0500 Received: from mga05.intel.com ([192.55.52.43]:55169 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755738AbdLUV3n (ORCPT ); Thu, 21 Dec 2017 16:29:43 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,437,1508828400"; d="scan'208";a="3860843" Date: Thu, 21 Dec 2017 14:29:43 -0700 From: Ross Zwisler To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, Ross Zwisler , Dave Hansen , linux-mm@kvack.org, Josh Triplett , Matthew Wilcox Subject: Re: [PATCH 1/2] mm: Make follow_pte_pmd an inline Message-ID: <20171221212943.GB9087@linux.intel.com> References: <20171219165823.24243-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171219165823.24243-1-willy@infradead.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 19, 2017 at 08:58:22AM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > The one user of follow_pte_pmd (dax) emits a sparse warning because > it doesn't know that follow_pte_pmd conditionally returns with the > pte/pmd locked. The required annotation is already there; it's just > in the wrong file. Can you help me find the required annotation that is already there but in the wrong file? This does seem to quiet a lockep warning in fs/dax.c, but I think we still have a related one in mm/memory.c: mm/memory.c:4204:5: warning: context imbalance in '__follow_pte_pmd' - different lock contexts for basic block Should we deal with this one as well?