Re: [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series

From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: "Andreas Färber" <afaerber@suse.de>,
	"Philippe Ombredanne" <pombredanne@nexb.com>
Cc: "Türk, Jan" <Jan.Tuerk@emtrion.de>,
	"'Rob Herring'" <robh@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"David Airlie" <airlied@linux.ie>,
	"Russell King" <linux@armlinux.org.uk>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"Fabio Estevam" <fabio.estevam@nxp.com>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Maxime Ripard" <maxime.ripard@free-electrons.com>,
	"SZ Lin" <sz.lin@moxa.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	LinuxArmKernelMailingListe <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series
Date: Fri, 22 Dec 2017 11:56:42 +0100	[thread overview]
Message-ID: <20171222105642.GD18255@piout.net> (raw)
In-Reply-To: <b41bc779-28e8-5a87-6f66-f5874dba8d1e@suse.de>

+ Philippe

On 22/12/2017 at 11:43:33 +0100, Andreas Färber wrote:
> >> I'll change it for v3 of this patch however it will end up like this:
> >> //SPDX-License...
> > 
> > That should be /* SPDX-License */, // is for c files.
> 
> Got any reference for that? Since we're using the C preprocessor before
> feeding them to dtc, we can use the same // style for both, builds fine.
> 
> Only for my private DT overlay files that I use directly with dtc I
> couldn't adopt that style.
> 
The doc states:

If a specific tool cannot handle the standard comment style, then the
appropriate comment mechanism which the tool accepts shall be used. This
is the reason for having the "/\* \*/" style comment in C header
files.

I interpreted that as dtc doesn't handle // comments, use /**/

But I agree it also states:
.dts{i}:	  // SPDX-License-Identifier: <SPDX License Expression>

So I think we will end up with a mix of both.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com