From: Steven Rostedt <rostedt@goodmis.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
x86@kernel.org, Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [RFC][PATCH][REGRESSION FIX] x86/ftrace: Add ORC annotation to 64 bit ftrace assembly
Date: Fri, 22 Dec 2017 13:38:01 -0500 [thread overview]
Message-ID: <20171222133801.3c9b1078@gandalf.local.home> (raw)
In-Reply-To: <20171222183024.47yadfkznhwhrlgf@treble>
On Fri, 22 Dec 2017 12:30:24 -0600
Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> I'm officially on vacation but I got a chance to look at this myself a
> few minutes ago. This looks mostly right. In theory, you should able
> to mark those as functions by changing END to ENDPROC. Then you won't
> need all the UNWIND_HINT_FUNCs.
Yep, that was my first solution, but as you found, objtool complained
about it.
>
> I tried making that change, but objtool thinks the stack frame is still
> modified when the functions return. I didn't see anything obvious in
> save_mcount_regs or restore_mcount_regs that should cause it to think
> that. I'll need to look into it a little more.
Thanks!
Worse comes to worse, we can keep this change, and you can enjoy your
holidays. I just need this fixed before 4.15 is released.
I'll be jumping into objtool shortly, to see if I can merge the code
from recordmcount.c with it too. I'm going to need to learn ORC and
DWARF to start on extending the function tracer to act more like
tracepoints (like I discussed with Linus in Prague).
-- Steve
next prev parent reply other threads:[~2017-12-22 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 18:18 [RFC][PATCH][REGRESSION FIX] x86/ftrace: Add ORC annotation to 64 bit ftrace assembly Steven Rostedt
2017-12-22 18:30 ` Josh Poimboeuf
2017-12-22 18:38 ` Steven Rostedt [this message]
2017-12-23 2:43 ` Josh Poimboeuf
2017-12-23 5:51 ` Steven Rostedt
2018-01-23 4:07 ` [PATCH] x86/ftrace: Fix ORC unwinding from ftrace handlers Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171222133801.3c9b1078@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).