From: Petr Mladek <pmladek@suse.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Kevin Hilman <khilman@baylibre.com>,
Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCHv3] printk: add console_msg_format command line option
Date: Fri, 22 Dec 2017 15:30:24 +0100 [thread overview]
Message-ID: <20171222143024.awvhdl2jhwj7hwes@pathway.suse.cz> (raw)
In-Reply-To: <20171221054149.4398-1-sergey.senozhatsky@gmail.com>
On Thu 2017-12-21 14:41:49, Sergey Senozhatsky wrote:
> This patch introduces a `console_msg_format=' command line option,
> to switch between different message formatting on serial consoles.
> For the time being we have just two options - default and syslog.
> The "default" option just keeps the existing format. While the
> "syslog" option makes serial console messages to appear in syslog
> format [syslog() syscall], matching the `dmesg -S --raw' and
> `cat /proc/kmsg' output formats:
>
> - facility and log level
> - time stamp (depends on printk_time/PRINTK_TIME)
> - message
>
> <%u>[time stamp] text\n
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Reviewed-by: Fengguang Wu <fengguang.wu@intel.com>
> Reviewed-by: Kevin Hilman <khilman@baylibre.com>
> Tested-by: Kevin Hilman <khilman@baylibre.com>
The patch looks and works good for me.
Reviewed-by: Petr Mladek <pmladek@suse.com>
I am going to add it into for-4.16 branch when I am back in January.
The patch is basically innocent. But I do not want to eventually
screw up printk.git with a last minute commit.
Best Regards,
Petr
prev parent reply other threads:[~2017-12-22 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 8:42 [PATCHv2] printk: add console_msg_format command line option Sergey Senozhatsky
2017-12-19 15:17 ` Steven Rostedt
2017-12-19 15:32 ` Sergey Senozhatsky
2017-12-21 5:41 ` [PATCHv3] " Sergey Senozhatsky
2017-12-22 14:30 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171222143024.awvhdl2jhwj7hwes@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).