From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Baoquan He <bhe@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@amacapital.net>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Atsushi Kumagai <ats-kumagai@wm.jp.nec.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm/sparse.c: Wrong allocation for mem_section
Date: Sat, 23 Dec 2017 12:54:19 +0300 [thread overview]
Message-ID: <20171223095419.73wtz3qyou675zfk@node.shutemov.name> (raw)
In-Reply-To: <1513932498-20350-1-git-send-email-bhe@redhat.com>
On Fri, Dec 22, 2017 at 04:48:18PM +0800, Baoquan He wrote:
> In commit
>
> 83e3c48729 "mm/sparsemem: Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y"
>
> mem_section is allocated at runtime to save memory. While it allocates
> the first dimension of array with sizeof(struct mem_section). It costs
> extra memory, should be sizeof(struct mem_section*).
>
> Fix it.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> Tested-by: Dave Young <dyoung@redhat.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Atsushi Kumagai <ats-kumagai@wm.jp.nec.com>
> Cc: linux-mm@kvack.org
Ughh. Sorry.
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Please queue it to stable.
--
Kirill A. Shutemov
prev parent reply other threads:[~2017-12-23 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 8:48 [PATCH] mm/sparse.c: Wrong allocation for mem_section Baoquan He
2017-12-23 9:54 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171223095419.73wtz3qyou675zfk@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=ats-kumagai@wm.jp.nec.com \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).