From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757161AbdLWQO3 (ORCPT ); Sat, 23 Dec 2017 11:14:29 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:48064 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752279AbdLWQO1 (ORCPT ); Sat, 23 Dec 2017 11:14:27 -0500 Date: Sat, 23 Dec 2017 17:14:28 +0100 From: "gregkh@linuxfoundation.org" To: "Ghorai, Sukumar" Cc: Brian Norris , Guenter Roeck , Matthias Kaehlcke , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "Bag, Amit K" , Oliver Neukum , Marcel Holtmann , Todd Broch , Rajat Jain , Miao Chou , "Rao Pv, Sadashiva" Subject: Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature Message-ID: <20171223161428.GB21326@kroah.com> References: <20171221191057.GA222103@google.com> <20171221200457.GB24020@roeck-us.net> <20171221204618.GB29509@kroah.com> <20171221205057.GC29509@kroah.com> <20171221213941.GD24020@roeck-us.net> <20171222074828.GA15565@kroah.com> <20171222173747.GB127515@google.com> <20171223091836.GF13832@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 23, 2017 at 03:53:57PM +0000, Ghorai, Sukumar wrote: > >> > included in 4.14-rc1, so something needs to be done in Linus's tree > >> > to resolve this issue, otherwise people will hit this as a > >> > regression when moving to 4.14 or newer. > >> > >> Well, I wouldn't object to reverting it in Linus' tree too, since > >> AFAIK, this is something that can be configured by user-space policy, > >> no? And that way, no user space is surprised by the sudden additional > >> requirements on managing bluetooth wakeup. > Wakeup from Bluetooth will be observed as long as USB wakeup is configured from > user space or kernel space or connected to any Bluetooth HID devices. > And we don't want to support the wakeup from BT HID devide. > The solution looks like disable Bluetooth in S3 entry? > Looks we are trying to hide the other problems in a system, and reverting this patch. > > > > >I agree, please work with the bluetooth developers to make this happen. > >They seem to be ignoring patches right now, so you might have to kick them a few > >times :( > Do you suggest submitter to send the revert request to 4.12 and 4.14 kernel? 4.12 is long end-of-life, I don't know what you expect to happen there. 4.14 is already released, this needs to be done for 4.15 first, right? thanks, greg k-h