From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Alexander.Steffen@infineon.com
Cc: chiu@endlessm.com, peterhuewe@gmx.de, jgg@ziepe.ca,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@endlessm.com
Subject: Re: TPM driver breaks S3 suspend
Date: Sun, 24 Dec 2017 22:37:51 +0200 [thread overview]
Message-ID: <20171224203751.2cyemyq7ugy3uquy@linux.intel.com> (raw)
In-Reply-To: <5dbce6c25e7e499aaac05269ba3c0f73@infineon.com>
> The correct solution should be something like tpm2_auto_startup
> (execute selftests, if they fail because of the missing startup
> command, execute that and retry the selftests). Interestingly,
> tpm1_auto_startup (same purpose as tpm2_auto_startup, but for TPM 1.2
> instead) does not use the same sequence, the startup-retry part is
> missing. Is there any reason this is done differently for TPM 1.2?
> Otherwise I'd propose to make tpm1_auto_startup follow the same
> sequence as tpm2_auto_startup and then call both from tpm_tis_resume,
> similar to what tpm_chip_register does.
I think the reason for that is that such regression has never reported
on TPM 1.2 platform. No other reason.
/Jarkko
next prev parent reply other threads:[~2017-12-24 20:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 8:04 TPM driver breaks S3 suspend Chris Chiu
2017-12-21 9:22 ` Paul Menzel
2017-12-21 9:43 ` Chris Chiu
2017-12-24 20:35 ` Jarkko Sakkinen
2017-12-21 10:19 ` Alexander.Steffen
2017-12-21 16:17 ` Jason Gunthorpe
2017-12-22 2:05 ` Chris Chiu
2017-12-22 13:34 ` Alexander.Steffen
2017-12-24 20:37 ` Jarkko Sakkinen [this message]
2017-12-24 20:33 ` Jarkko Sakkinen
2017-12-25 2:43 ` Chris Chiu
2018-01-02 14:43 ` Jarkko Sakkinen
2018-03-15 10:11 ` Daniel Drake
2018-03-16 13:44 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171224203751.2cyemyq7ugy3uquy@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Alexander.Steffen@infineon.com \
--cc=chiu@endlessm.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).