From: Stephen Boyd <sboyd@codeaurora.org>
To: Dong Aisheng <aisheng.dong@nxp.com>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, mturquette@baylibre.com
Subject: Re: [RFC PATCH V1 2/2] clk: add lock for clk_core_is_enabled
Date: Tue, 26 Dec 2017 17:29:18 -0800 [thread overview]
Message-ID: <20171227012918.GU7997@codeaurora.org> (raw)
In-Reply-To: <1513935965-12909-2-git-send-email-aisheng.dong@nxp.com>
On 12/22, Dong Aisheng wrote:
> According to design doc, .is_enabled should be protected by enable lock.
> Then users don't have to protect it against enable/disable operation
> in clock drivers.
>
> See: Documentation/clk.txt
> "The enable lock is a spinlock and is held across calls to the .enable,
> .disable and .is_enabled operations."
>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> drivers/clk/clk.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index e24968f..d6e2d5c 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -198,14 +198,19 @@ static bool clk_core_is_prepared(struct clk_core *core)
>
> static bool clk_core_is_enabled(struct clk_core *core)
> {
> + unsigned long flags;
> bool ret = false;
>
> + flags = clk_enable_lock();
> +
> /*
> * .is_enabled is only mandatory for clocks that gate
> * fall back to software usage counter if .is_enabled is missing
> */
> - if (!core->ops->is_enabled)
> + if (!core->ops->is_enabled) {
> + clk_enable_unlock(flags);
> return core->enable_count;
> + }
>
> /*
> * Check if clock controller's device is runtime active before
> @@ -230,6 +235,8 @@ static bool clk_core_is_enabled(struct clk_core *core)
> if (core->dev)
> pm_runtime_put(core->dev);
>
> + clk_enable_unlock(flags);
> +
> return ret;
> }
It doesn't really make any sense to hold the enable lock inside
the clk_core_is_enabled() function, unless you want to do
something else with the information of the enable state with that
lock held. Otherwise, seeing if a clk is enabled is a one-shot
read of the enabled state, which could just as easily change
after the function returns because the lock is released.
We should update the documentation.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-12-27 1:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 9:46 [RFC PATCH V1 1/2] clk: use atomic runtime pm api in clk_core_is_enabled Dong Aisheng
2017-12-22 9:46 ` [RFC PATCH V1 2/2] clk: add lock for clk_core_is_enabled Dong Aisheng
2017-12-27 1:29 ` Stephen Boyd [this message]
2018-01-17 2:57 ` Dong Aisheng
2017-12-22 12:51 ` [RFC PATCH V1 1/2] clk: use atomic runtime pm api in clk_core_is_enabled Ulf Hansson
2017-12-27 1:38 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171227012918.GU7997@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=aisheng.dong@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).