From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751043AbdL0HKU (ORCPT ); Wed, 27 Dec 2017 02:10:20 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:36332 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750790AbdL0HKT (ORCPT ); Wed, 27 Dec 2017 02:10:19 -0500 X-Google-Smtp-Source: ACJfBov/Lb7DoEf4snezDh1MUXSyhh/bJAAP6ul8J0g4C7ljHe9w4Fte+pCKNMoMWwxxFpgumTqf9w== Date: Wed, 27 Dec 2017 16:10:56 +0900 From: Sergey Senozhatsky To: Gopi Sai Teja Cc: Minchan Kim , ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, v.narang@samsung.com, pankaj.m@samsung.com, a.sahrawat@samsung.com, prakash.a@samsung.com, himanshu.sh@samsung.com, lalit.mohan@samsung.com Subject: Re: [PATCH v2] zram: better utilization of zram swap space Message-ID: <20171227071056.GA471@jagdpanzerIV> References: <1513938606-17735-1-git-send-email-gopi.st@samsung.com> <20171227062946.GA11295@bgram> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171227062946.GA11295@bgram> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (12/27/17 15:29), Minchan Kim wrote: > On Fri, Dec 22, 2017 at 04:00:06PM +0530, Gopi Sai Teja wrote: > > 75% of the PAGE_SIZE is not a correct threshold to store uncompressed > > Please describe it in detail that why current threshold is bad in that > memory efficiency point of view. > > > pages in zs_page as this must be changed if the maximum pages stored > > in zspage changes. Instead using zs classes, we can set the correct > > Also, let's include the pharase Sergey pointed out in this description. > > It's not a good idea that zram need to know allocator's implementation > with harded value like 75%. so I don't like that, basically, my work and my findings are now submitted by someone else without even crediting my work. not to mention that I like my commit message much better. -ss