From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Gopi Sai Teja <gopi.st@samsung.com>,
ngupta@vflare.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, v.narang@samsung.com,
pankaj.m@samsung.com, a.sahrawat@samsung.com,
prakash.a@samsung.com, himanshu.sh@samsung.com,
lalit.mohan@samsung.com
Subject: Re: [PATCH v2] zram: better utilization of zram swap space
Date: Thu, 28 Dec 2017 09:00:04 +0900 [thread overview]
Message-ID: <20171228000004.GB10532@bbox> (raw)
In-Reply-To: <20171227071056.GA471@jagdpanzerIV>
On Wed, Dec 27, 2017 at 04:10:56PM +0900, Sergey Senozhatsky wrote:
> On (12/27/17 15:29), Minchan Kim wrote:
> > On Fri, Dec 22, 2017 at 04:00:06PM +0530, Gopi Sai Teja wrote:
> > > 75% of the PAGE_SIZE is not a correct threshold to store uncompressed
> >
> > Please describe it in detail that why current threshold is bad in that
> > memory efficiency point of view.
> >
> > > pages in zs_page as this must be changed if the maximum pages stored
> > > in zspage changes. Instead using zs classes, we can set the correct
> >
> > Also, let's include the pharase Sergey pointed out in this description.
> >
> > It's not a good idea that zram need to know allocator's implementation
> > with harded value like 75%.
>
> so I don't like that, basically, my work and my findings are
> now submitted by someone else without even crediting my work.
> not to mention that I like my commit message much better.
>
> -ss
Gopi Sai Teja, please discuss with Sergey about patch credit.
next prev parent reply other threads:[~2017-12-28 0:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171222103443epcas5p41f45e1a99146aac89edd63f76a3eb62a@epcas5p4.samsung.com>
2017-12-22 10:30 ` [PATCH v2] zram: better utilization of zram swap space Gopi Sai Teja
2017-12-27 6:29 ` Minchan Kim
2017-12-27 7:10 ` Sergey Senozhatsky
2017-12-28 0:00 ` Minchan Kim [this message]
2017-12-29 7:26 ` Minchan Kim
2017-12-29 9:21 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171228000004.GB10532@bbox \
--to=minchan@kernel.org \
--cc=a.sahrawat@samsung.com \
--cc=gopi.st@samsung.com \
--cc=himanshu.sh@samsung.com \
--cc=lalit.mohan@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=pankaj.m@samsung.com \
--cc=prakash.a@samsung.com \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=v.narang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).