From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751436AbdL2QW5 (ORCPT ); Fri, 29 Dec 2017 11:22:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:60804 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869AbdL2QWz (ORCPT ); Fri, 29 Dec 2017 11:22:55 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3AA32197D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Fri, 29 Dec 2017 16:22:50 +0000 From: Jonathan Cameron To: Eugen Hristev Cc: , , , , , , , , Subject: Re: [PATCH 10/14] iio: adc: at91-sama5d2_adc: force trigger removal on module remove Message-ID: <20171229162250.7d68a0c8@archlinux> In-Reply-To: <1513955241-10985-11-git-send-email-eugen.hristev@microchip.com> References: <1513955241-10985-1-git-send-email-eugen.hristev@microchip.com> <1513955241-10985-11-git-send-email-eugen.hristev@microchip.com> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Dec 2017 17:07:17 +0200 Eugen Hristev wrote: > On module remove, if we do not call trigger remove, the trigger > stays in the subsystem, and on further module insert, we will have > multiple triggers, and the old one is not usable. > Have to call the remove function on module remove to solve this. > > Signed-off-by: Eugen Hristev This needs more explanation. I can't see why the managed removal isn't sufficient. On removal the dev should have gone away taking the trigger with it. If it isn't then it looks like a straight forward bug that needs fixing. Jonathan > --- > drivers/iio/adc/at91-sama5d2_adc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c > index 4eff835..7b9febc 100644 > --- a/drivers/iio/adc/at91-sama5d2_adc.c > +++ b/drivers/iio/adc/at91-sama5d2_adc.c > @@ -1180,6 +1180,9 @@ static int at91_adc_remove(struct platform_device *pdev) > struct iio_dev *indio_dev = platform_get_drvdata(pdev); > struct at91_adc_state *st = iio_priv(indio_dev); > > + if (st->selected_trig->hw_trig) > + devm_iio_trigger_unregister(&indio_dev->dev, st->trig); > + > iio_device_unregister(indio_dev); > > at91_adc_dma_disable(pdev);