linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Pablo Neira Ayuso <pablo@netfilter.org>,
	NetFilter <netfilter-devel@vger.kernel.org>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: linux-next: build warning after merge of the netfilter-next tree
Date: Tue, 2 Jan 2018 12:14:51 +1100	[thread overview]
Message-ID: <20180102121451.3f8f792d@canb.auug.org.au> (raw)

Hi all,

After merging the netfilter-next tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from net/ipv6/af_inet6.c:45:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
  int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                   ^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/route.c:87:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
 int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                     ^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/ip6_input.c:34:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
  int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                   ^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/ip_input.c:145:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
 int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                     ^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/ip_fragment.c:50:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
 int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                     ^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/ip6_output.c:44:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
  int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                   ^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/ip_forward.c:37:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
 int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                     ^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/ndisc.c:74:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
  int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                   ^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/ip_output.c:79:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
 int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                     ^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/raw.c:32:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
  int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                   ^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/xfrm6_state.c:18:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
  int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                   ^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/mcast.c:51:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
  int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                   ^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/xfrm6_input.c:16:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
  int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                   ^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/xfrm6_output.c:17:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
  int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                   ^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/xfrm4_output.c:15:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
 int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                     ^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/raw.c:79:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
 int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                     ^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/xfrm4_input.c:17:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
 int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                     ^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/ip_tunnel_core.c:30:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
 int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                     ^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/sit.c:36:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
 int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                     ^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/icmp.c:78:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
 int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                     ^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/xfrm4_state.c:15:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
 int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                     ^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/igmp.c:102:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
 int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                     ^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/af_inet.c:89:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
 int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                     ^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/ip_tunnel.c:37:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
 int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                     ^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/ip6_tunnel.c:40:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
  int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
                                                   ^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want

Introduced by commit

  9faa679ee7ec ("netfilter: move reroute indirection to struct nf_ipv6_ops")

-- 
Cheers,
Stephen Rothwell

             reply	other threads:[~2018-01-02  1:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-02  1:14 Stephen Rothwell [this message]
2018-01-02 15:30 ` linux-next: build warning after merge of the netfilter-next tree Pablo Neira Ayuso
  -- strict thread matches above, loose matches on Subject: below --
2020-03-30  0:26 Stephen Rothwell
2018-05-07  0:55 Stephen Rothwell
2018-05-08  0:21 ` Stephen Rothwell
2018-05-08  7:17   ` Florian Westphal
2018-05-15 10:54     ` Geert Uytterhoeven
2018-05-15 17:51       ` Florian Westphal
2017-11-07  0:02 Stephen Rothwell
2017-11-08  8:00 ` Stephen Rothwell
2017-11-08 23:40   ` Pablo Neira Ayuso
2017-11-15 22:46     ` Stephen Rothwell
2017-11-16 14:18       ` Pablo Neira Ayuso
2017-11-16 20:46         ` Stephen Rothwell
2017-03-20  0:12 Stephen Rothwell
2017-03-20  7:00 ` Reshetova, Elena
2017-03-20  8:44   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180102121451.3f8f792d@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).