linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Zeitlhofer <thomas.zeitlhofer+lkml@ze-it.at>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Hugh Dickins <hughd@google.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: "BUG: using smp_processor_id() in preemptible" with KPTI on 4.14.11
Date: Thu, 4 Jan 2018 19:38:00 +0100	[thread overview]
Message-ID: <20180104183800.ewx42etmmzk5b544@toau> (raw)
In-Reply-To: <20180104170712.GB3040@hirez.programming.kicks-ass.net>

On Thu, Jan 04, 2018 at 06:07:12PM +0100, Peter Zijlstra wrote:
> On Thu, Jan 04, 2018 at 04:37:24PM +0100, Thomas Gleixner wrote:
> > > Yes:
> > > 
> > >    BUG: using smp_processor_id() in preemptible [00000000] code: ovsdb-server/4498
> > >    caller is native_flush_tlb_single+0x57/0xc0
> > >    CPU: 2 PID: 4498 Comm: ovsdb-server Not tainted 4.15.0-rc6-kvm-00423-gea1908c252eb #3
> > >    Hardware name: MSI MS-7798/B75MA-P45 (MS-7798), BIOS V1.9 09/30/2013
> > >    Call Trace:
> > >     dump_stack+0x5c/0x86
> > >     check_preemption_disabled+0xdd/0xe0
> > >     native_flush_tlb_single+0x57/0xc0
> > >     ? __set_pte_vaddr+0x2d/0x40
> > >     __set_pte_vaddr+0x2d/0x40
> > >     set_pte_vaddr+0x2f/0x40
> > >     cea_set_pte+0x30/0x40
> > >     ds_update_cea.constprop.4+0x4d/0x70
> > >     reserve_ds_buffers+0x159/0x410
> > >     ? wp_page_copy+0x370/0x6c0
> > >     x86_reserve_hardware+0x150/0x160
> > >     x86_pmu_event_init+0x3e/0x1f0
> > >     perf_try_init_event+0x69/0x80
> > >     perf_event_alloc+0x652/0x740
> > >     SyS_perf_event_open+0x3f6/0xd60
> > >     do_syscall_64+0x5c/0x190
> > >     entry_SYSCALL64_slow_path+0x25/0x25
> > >    RIP: 0033:0x72bff0a3c0b9
> > >    RSP: 002b:00007ffed11c2f18 EFLAGS: 00000206 ORIG_RAX: 000000000000012a
> > >    RAX: ffffffffffffffda RBX: 00007ffed11c30f0 RCX: 000072bff0a3c0b9
> > >    RDX: 00000000ffffffff RSI: 0000000000000000 RDI: 00007ffed11c2f20
> > >    RBP: 0000000000000000 R08: 0000000000000000 R09: 0000007000000000
> > >    R10: 00000000ffffffff R11: 0000000000000206 R12: 0000000000000008
> > >    R13: 0000000000000000 R14: 00007ffed11c30d0 R15: 000060986ecfb600
> 
> Fun, so set_pte_vaddr() and the whole cpu_entry_area are supposed to be
> per CPU. But the DS crud does cross CPU updates of those tables.
> 
> So we need some additional fun and games..
> 
> How's the below?
[...]

Looks good - I have successfully tested it on top of 4.14.11 and
4.15-rc6. In both cases, the error message is gone when this patch is
applied.

Thanks,

Thomas

  reply	other threads:[~2018-01-04 18:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-04  1:59 "BUG: using smp_processor_id() in preemptible" with KPTI on 4.14.11 Thomas Zeitlhofer
2018-01-04 10:20 ` Thomas Zeitlhofer
2018-01-04 10:51   ` Greg Kroah-Hartman
2018-01-04 12:43     ` Thomas Zeitlhofer
2018-01-04 12:55       ` Greg Kroah-Hartman
2018-01-04 15:25         ` Thomas Zeitlhofer
2018-01-04 15:37           ` Thomas Gleixner
2018-01-04 17:07             ` Peter Zijlstra
2018-01-04 18:38               ` Thomas Zeitlhofer [this message]
2018-01-06 21:38                 ` Thomas Zeitlhofer
2018-01-07  8:17                   ` Greg Kroah-Hartman
2018-01-07  8:53                     ` Thomas Zeitlhofer
2018-01-08  0:37                       ` Thomas Zeitlhofer
2018-01-04 22:11               ` [tip:x86/pti] x86/events/intel/ds: Use the proper cache flush method for mapping ds buffers tip-bot for Peter Zijlstra
2018-01-04 23:49               ` tip-bot for Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180104183800.ewx42etmmzk5b544@toau \
    --to=thomas.zeitlhofer+lkml@ze-it.at \
    --cc=gregkh@linuxfoundation.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).