Re: [PATCH 01/12] perf tools: Enable LIBBABELTRACE by default

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	lkml <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	David Ahern <dsahern@gmail.com>, Andi Kleen <ak@linux.intel.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: Re: [PATCH 01/12] perf tools: Enable LIBBABELTRACE by default
Date: Mon, 8 Jan 2018 12:20:37 -0300	[thread overview]
Message-ID: <20180108152037.GJ25476@kernel.org> (raw)
In-Reply-To: <20180108151709.GI25476@kernel.org>

Em Mon, Jan 08, 2018 at 12:17:09PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Sun, Jan 07, 2018 at 05:03:45PM +0100, Jiri Olsa escreveu:
> > There's no reason anymore to treat babel trace in a special way,
> > because a) we no longer display its state b) the needed babeltrace
> > library is now out and well adopted among distros.
> 
> Humm, after I applied this I got:
> 
> [acme@jouet perf]$ perf
> perf: error while loading shared libraries: libbabeltrace-ctf.so.2: cannot open shared object file: No such file or directory
> [acme@jouet perf]$
> 
> So it detects it somehow, builds with it, then fails to find it in the
> LD_LIBRARY_PATH somehow?

[acme@jouet perf]$ ldd ~/bin/perf | grep babel
	libbabeltrace-ctf.so.2 => not found
[acme@jouet perf]$

[acme@jouet perf]$ tail -5 /tmp/build/perf/feature/test-libbabeltrace.d 
 /usr/local/include/babeltrace/ctf-ir/visitor.h \
 /usr/local/include/babeltrace/values.h \
 /usr/local/include/babeltrace/ref.h \
 /usr/local/include/babeltrace/graph/notification.h \
 /usr/local/include/babeltrace/ctf-ir/stream-class.h
[acme@jouet perf]$

so I don't have it in LD_LIBRARY_PATH:

[acme@jouet perf]$ export LD_LIBRARY_PATH=/usr/local/lib/
[acme@jouet perf]$ ldd ~/bin/perf | grep babel
	libbabeltrace-ctf.so.2 => /usr/local/lib/libbabeltrace-ctf.so.2 (0x00007f6322e83000)
[acme@jouet perf]$ perf stat -e cycles sleep 1

 Performance counter stats for 'sleep 1':

           384,636      cycles:u                                                    

       1.001294682 seconds time elapsed

[acme@jouet perf]$ 

Will try removing this local install and use what is in fedora27
instead...

> - Arnaldo
>  
> > Link: http://lkml.kernel.org/n/tip-n1c2a8hwtf6wlh8e0uiqn8in@git.kernel.org
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> >  tools/perf/Makefile.config | 2 +-
> >  tools/perf/Makefile.perf   | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> > index f050f38d8fa3..12dec6ea5ed2 100644
> > --- a/tools/perf/Makefile.config
> > +++ b/tools/perf/Makefile.config
> > @@ -780,7 +780,7 @@ else
> >    NO_PERF_READ_VDSOX32 := 1
> >  endif
> >  
> > -ifdef LIBBABELTRACE
> > +ifndef NO_LIBBABELTRACE
> >    $(call feature_check,libbabeltrace)
> >    ifeq ($(feature-libbabeltrace), 1)
> >      CFLAGS += -DHAVE_LIBBABELTRACE_SUPPORT $(LIBBABELTRACE_CFLAGS)
> > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> > index 68cf1360a3f3..9fdefd748e2e 100644
> > --- a/tools/perf/Makefile.perf
> > +++ b/tools/perf/Makefile.perf
> > @@ -77,7 +77,7 @@ include ../scripts/utilities.mak
> >  #
> >  # Define NO_ZLIB if you do not want to support compressed kernel modules
> >  #
> > -# Define LIBBABELTRACE if you DO want libbabeltrace support
> > +# Define NO_LIBBABELTRACE if you do not want libbabeltrace support
> >  # for CTF data format.
> >  #
> >  # Define NO_LZMA if you do not want to support compressed (xz) kernel modules
> > -- 
> > 2.13.6