From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934207AbeAHPoX (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Mon, 8 Jan 2018 10:44:23 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:37556 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932282AbeAHPoW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 8 Jan 2018 10:44:22 -0500
Date: Mon, 8 Jan 2018 16:44:24 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Sumit Pundir <pundirsumit11@gmail.com>
Cc: forest@alittletooquiet.net, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: vt6656: fix unnecessary parantheses
Message-ID: <20180108154424.GA12786@kroah.com>
References: <1513952632-26737-1-git-send-email-pundirsumit11@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1513952632-26737-1-git-send-email-pundirsumit11@gmail.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Fri, Dec 22, 2017 at 07:53:52PM +0530, Sumit Pundir wrote:
> This patch fixes a coding style issue as noted by
> checkpatch.pl related to unnecessary parentheses.
> 
> This patch fixes the following checkpatch.pl warning:
> 
> WARNING: Unnecessary parentheses around 'priv->basic_rates'.
> 
> Signed-off-by: Sumit Pundir <pundirsumit11@gmail.com>
> ---
>  drivers/staging/vt6656/card.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
> index 501f482..811602e 100644
> --- a/drivers/staging/vt6656/card.c
> +++ b/drivers/staging/vt6656/card.c
> @@ -443,7 +443,7 @@ int vnt_ofdm_min_rate(struct vnt_private *priv)
>  	int ii;
> 
>  	for (ii = RATE_54M; ii >= RATE_6M; ii--) {
> -		if ((priv->basic_rates) & ((u16)BIT(ii)))
> +		if (priv->basic_rates & ((u16)BIT(ii)))

You still have one too many () around the BIT stuff...