From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934214AbeAHPpZ (ORCPT + 1 other); Mon, 8 Jan 2018 10:45:25 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37916 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932282AbeAHPpY (ORCPT ); Mon, 8 Jan 2018 10:45:24 -0500 Date: Mon, 8 Jan 2018 16:45:26 +0100 From: Greg KH To: Sumit Pundir Cc: devel@driverdev.osuosl.org, forest@alittletooquiet.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: vt6656: Fix unnecessary parantheses Message-ID: <20180108154526.GB12786@kroah.com> References: <1514180134-7578-1-git-send-email-pundirsumit11@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1514180134-7578-1-git-send-email-pundirsumit11@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Dec 25, 2017 at 11:05:34AM +0530, Sumit Pundir wrote: > This patch fixes a few coding style issues as noted by checkpatch.pl > related to unnecessary parantheses. > > This patch fixes the following checkpatch.pl warnings: > > WARNING: Unnecessary parentheses around 'priv->eeprom[EEP_OFS_MAJOR_VER] == 0x1' > WARNING: Unnecessary parentheses around 'priv->eeprom[EEP_OFS_MINOR_VER] >= 0x4' > > Signed-off-by: Sumit Pundir > --- > drivers/staging/vt6656/main_usb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c > index 1b51b83..c15ae72 100644 > --- a/drivers/staging/vt6656/main_usb.c > +++ b/drivers/staging/vt6656/main_usb.c > @@ -266,8 +266,8 @@ static int vnt_init_registers(struct vnt_private *priv) > > /* load vt3266 calibration parameters in EEPROM */ > if (priv->rf_type == RF_VT3226D0) { > - if ((priv->eeprom[EEP_OFS_MAJOR_VER] == 0x1) && > - (priv->eeprom[EEP_OFS_MINOR_VER] >= 0x4)) { > + if (priv->eeprom[EEP_OFS_MAJOR_VER] == 0x1 && > + priv->eeprom[EEP_OFS_MINOR_VER] >= 0x4) { No, now you have to guess if && or == or >= comes first :(