From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757360AbeAHRQz (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Mon, 8 Jan 2018 12:16:55 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50002 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751426AbeAHRQx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 8 Jan 2018 12:16:53 -0500
Date: Mon, 8 Jan 2018 18:16:49 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        David Ahern <dsahern@gmail.com>,
        Andi Kleen <ak@linux.intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: Re: [PATCH 01/12] perf tools: Enable LIBBABELTRACE by default
Message-ID: <20180108171649.GD18380@krava>
References: <20180107160356.28203-1-jolsa@kernel.org>
 <20180107160356.28203-2-jolsa@kernel.org>
 <20180108151709.GI25476@kernel.org>
 <20180108152037.GJ25476@kernel.org>
 <20180108152433.GK25476@kernel.org>
 <20180108171122.GC18380@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180108171122.GC18380@krava>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 08 Jan 2018 17:16:53 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Mon, Jan 08, 2018 at 06:11:22PM +0100, Jiri Olsa wrote:
> On Mon, Jan 08, 2018 at 12:24:33PM -0300, Arnaldo Carvalho de Melo wrote:
> 
> SNIP
> 
> > 
> > Works:
> > 
> > [acme@jouet perf]$ ldd ~/bin/perf | grep babel
> > 	libbabeltrace-ctf.so.1 => /lib64/libbabeltrace-ctf.so.1 (0x00007fcb688d0000)
> > 	libbabeltrace.so.1 => /lib64/libbabeltrace.so.1 (0x00007fcb67e92000)
> > [acme@jouet perf]$ rpm -q libbabeltrace-devel
> > libbabeltrace-devel-1.5.3-1.fc27.x86_64
> > [acme@jouet perf]$
> > 
> > But then, if we show:
> > 
> > Auto-detecting system features:
> > ...                         dwarf: [ on  ]
> > ...            dwarf_getlocations: [ on  ]
> > ...                         glibc: [ on  ]
> > ...                          gtk2: [ on  ]
> > ...                      libaudit: [ on  ]
> > ...                        libbfd: [ on  ]
> > ...                        libelf: [ on  ]
> > ...                       libnuma: [ on  ]
> > ...        numa_num_possible_cpus: [ on  ]
> > ...                       libperl: [ on  ]
> > ...                     libpython: [ on  ]
> > ...                      libslang: [ on  ]
> > ...                     libcrypto: [ on  ]
> > ...                     libunwind: [ on  ]
> > ...            libdw-dwarf-unwind: [ on  ]
> > ...                          zlib: [ on  ]
> > ...                          lzma: [ on  ]
> > ...                     get_cpuid: [ on  ]
> > ...                           bpf: [ on  ]
> > 
> > Shoudln't we tell the user that babeltrace was linked too?
> 
> the logic is just to simply display the state of features
> which we provide in FEATURE_DISPLAY variable, which is
> believed to be common and important enough to display
> status about
> 
> maybe we could display it with 'make VF=1' output?

like in patch attached ;-)

	[jolsa@krava perf]$ make VF=1
	  BUILD:   Doing 'make -j4' parallel build
	Warning: Kernel ABI header at 'tools/include/uapi/linux/perf_event.h' differs from latest version at 'include/uapi/linux/perf_event.h'

	Auto-detecting system features:
	...                         dwarf: [ on  ]
	...            dwarf_getlocations: [ on  ]
	...                         glibc: [ on  ]
	...                          gtk2: [ on  ]
	...                      libaudit: [ on  ]
	...                        libbfd: [ on  ]
	...                        libelf: [ on  ]
	...                       libnuma: [ on  ]
	...        numa_num_possible_cpus: [ on  ]
	...                       libperl: [ on  ]
	...                     libpython: [ on  ]
	...                      libslang: [ on  ]
	...                     libcrypto: [ on  ]
	...                     libunwind: [ OFF ]
	...            libdw-dwarf-unwind: [ on  ]
	...                          zlib: [ on  ]
	...                          lzma: [ on  ]
	...                     get_cpuid: [ on  ]
	...                           bpf: [ on  ]
	...                     backtrace: [ on  ]
	...                fortify-source: [ on  ]
	...         sync-compare-and-swap: [ on  ]
	...                  gtk2-infobar: [ on  ]
	...             libelf-getphdrnum: [ on  ]
	...           libelf-gelf_getnote: [ on  ]
	...          libelf-getshdrstrndx: [ on  ]
	...                   libelf-mmap: [ on  ]
	...             libpython-version: [ on  ]
	...                 libunwind-x86: [ OFF ]
	...              libunwind-x86_64: [ OFF ]
	...                 libunwind-arm: [ OFF ]
	...             libunwind-aarch64: [ OFF ]
	...   pthread-attr-setaffinity-np: [ on  ]
	...               pthread-barrier: [ on  ]
	...            stackprotector-all: [ on  ]
	...                       timerfd: [ on  ]
	...                  sched_getcpu: [ on  ]
	...                           sdt: [ on  ]
	...                         setns: [ on  ]

	Makefile.config:459: No libunwind found. Please install libunwind-dev[el] >= 1.1 and/or set LIBUNWIND_DIR
	...                        bionic: [ OFF ]
	...                    compile-32: [ on  ]
	...                   compile-x32: [ OFF ]
	...                cplus-demangle: [ on  ]
	...                         hello: [ OFF ]
	...                 libbabeltrace: [ on  ]
	...                       liberty: [ on  ]
	...                     liberty-z: [ on  ]
	...         libunwind-debug-frame: [ OFF ]
	...     libunwind-debug-frame-arm: [ OFF ]
	... libunwind-debug-frame-aarch64: [ OFF ]
	...                        prefix: /home/jolsa
	...                        bindir: /home/jolsa/bin
	...                        libdir: /home/jolsa/lib64
	...                    sysconfdir: /home/jolsa/etc
	...                 LIBUNWIND_DIR: 
	...                     LIBDW_DIR: 
	...                          JDIR: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.151-1.b12.fc26.x86_64
	...     DWARF post unwind library: libdw


jirka

---
diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
index 12dec6ea5ed2..92265b32dddd 100644
--- a/tools/perf/Makefile.config
+++ b/tools/perf/Makefile.config
@@ -947,6 +947,10 @@ define print_var_code
 endef
 
 ifeq ($(VF),1)
+  # Display EXTRA features which are detected manualy
+  # from here with feature_check call and thus cannot
+  # be partof global state output.
+  $(foreach feat,$(FEATURE_TESTS_EXTRA),$(call feature_print_status,$(feat),))
   $(call print_var,prefix)
   $(call print_var,bindir)
   $(call print_var,libdir)