From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752120AbeAIJVU (ORCPT + 1 other); Tue, 9 Jan 2018 04:21:20 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:36422 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751515AbeAIJVP (ORCPT ); Tue, 9 Jan 2018 04:21:15 -0500 X-Google-Smtp-Source: ACJfBotqSFJItAkpP9gD84js3lne9+heiNQLltck9GdHGhdpyq4YP3PhtkC9WZfpbPuXQmCDXvXlzw== Date: Tue, 9 Jan 2018 10:21:12 +0100 From: Johan Hovold To: Dmitry Torokhov Cc: Johan Hovold , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable , Peter Ujfalusi , Marek Belisko Subject: Re: [PATCH 1/3] Input: twl4030-vibra: fix sibling-node lookup Message-ID: <20180109092112.GJ11344@localhost> References: <20171111154339.16875-1-johan@kernel.org> <20171211102121.GJ5672@localhost> <20180108135502.GF11344@localhost> <20180109013638.vjeou77idumazgcq@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180109013638.vjeou77idumazgcq@dtor-ws> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 08, 2018 at 05:36:38PM -0800, Dmitry Torokhov wrote: > On Mon, Jan 08, 2018 at 02:55:02PM +0100, Johan Hovold wrote: > > On Mon, Dec 11, 2017 at 11:21:21AM +0100, Johan Hovold wrote: > > > On Sat, Nov 11, 2017 at 04:43:37PM +0100, Johan Hovold wrote: > > > > A helper purported to look up a child node based on its name was using > > > > the wrong of-helper and ended up prematurely freeing the parent of-node > > > > while searching the whole device tree depth-first starting at the parent > > > > node. > > > > > > > > Fixes: 64b9e4d803b1 ("input: twl4030-vibra: Support for DT booted kernel") > > > > Fixes: e661d0a04462 ("Input: twl4030-vibra - fix ERROR: Bad of_node_put() warning") > > > > Cc: stable # 3.7 > > > > Cc: Peter Ujfalusi > > > > Cc: Marek Belisko > > > > Signed-off-by: Johan Hovold > > > > --- > > > > > > Just wanted to send a reminder about this series. I believe these bugs > > > need to be fixes regardless of whether MFD-core eventually provides some > > > means of avoiding such lookups in cell drivers (i.e. the discussion > > > which appears to have stalled). > > > > Another month, another reminder: Will you pick this series up for 4.16, > > Dmitry? > > Sorry, I was hoping we'd have some movement in MFD... Applied all 3, > thank you. No worries. The MFD changes can be done as follow-ons (when people can find some spare cycles). I agree with the general direction. Thanks, Johan