From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760079AbeAIRXX (ORCPT + 1 other); Tue, 9 Jan 2018 12:23:23 -0500 Received: from mx2.suse.de ([195.135.220.15]:48120 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760039AbeAIRXW (ORCPT ); Tue, 9 Jan 2018 12:23:22 -0500 Date: Tue, 9 Jan 2018 18:23:18 +0100 From: "Luis R. Rodriguez" To: Dongsu Park Cc: "Luis R. Rodriguez" , LKML , Linux Containers , Alban Crequy , "Eric W . Biederman" , Miklos Szeredi , Seth Forshee , Sargun Dhillon , linux-fsdevel@vger.kernel.org, Alexander Viro , Kees Cook Subject: Re: [PATCH 03/11] fs: Allow superblock owner to change ownership of inodes Message-ID: <20180109172318.GO22430@wotan.suse.de> References: <20180105192407.GF22430@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 09, 2018 at 04:10:54PM +0100, Dongsu Park wrote: > On Fri, Jan 5, 2018 at 8:24 PM, Luis R. Rodriguez wrote: > > On Fri, Dec 22, 2017 at 03:32:27PM +0100, Dongsu Park wrote: > > I think this patch would read much better and easier to review if it was > > split up by first adding the helpers, and then extending them afterwards. > > I'm fine with splitting it up into multiple patches, if the original author > Eric agrees. Great. > > Are we sure proc is the only special one? How was it observed first that this was > > require for proc? Has anyone tried fuzzing by trying this op with a slew of other > > filesystems on all files? > > Please let me know if there are other good ways to figure out potential issues. I think the trick would be to create a test which mimicks the issue and then try to mount and run the test against as many filesystems as we support. So would developing a test be possible here? Luis