From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933249AbeAJB5O (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Tue, 9 Jan 2018 20:57:14 -0500
Received: from one.firstfloor.org ([193.170.194.197]:60470 "EHLO
        one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933042AbeAJB5N (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 9 Jan 2018 20:57:13 -0500
Date: Tue, 9 Jan 2018 17:57:11 -0800
From: Andi Kleen <andi@firstfloor.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andi Kleen <andi@firstfloor.org>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        the arch/x86 maintainers <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        David Woodhouse <dwmw@amazon.co.uk>,
        Paul Turner <pjt@google.com>,
        Andrew Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linux-foundation.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Jiri Kosina <jikos@kernel.org>, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] x86/retpoline: Fix NOSPEC_JMP for tip
Message-ID: <20180110015711.h4aeezba755yww5o@two.firstfloor.org>
References: <20180110003139.10531-1-andi@firstfloor.org>
 <CA+55aFzyVFEUKaLpqxfwh5E9QFgMjzr+wVoYGxqTHVDkGcFkOw@mail.gmail.com>
 <alpine.DEB.2.20.1801100139560.2200@nanos>
 <184a65a3-6afe-4c82-7f7d-2c1d4a5198bc@amd.com>
 <20180110013009.5ysxlkuhczuv7uwg@two.firstfloor.org>
 <20180110013638.iqafe7nr7tbhwda6@two.firstfloor.org>
 <alpine.DEB.2.20.1801100248230.2200@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.20.1801100248230.2200@nanos>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Wed, Jan 10, 2018 at 02:50:12AM +0100, Thomas Gleixner wrote:
> On Tue, 9 Jan 2018, Andi Kleen wrote:
> 
> > > > I think there are areas that rely on X86_FEATURE_RETPOLINE being set
> > > > even if X86_FEATURE_RETPOLINE_AMD is set.  For example, line 261 in
> > > > arch/x86/entry/entry_32.S is only checking for X86_FEATURE_RETPOLINE.
> > > 
> > > I audited the difference places. They all seem ok.
> > 
> > Actually 32bit is not ok. For 32bit we need COMMON. So adding it.
> 
> Please keep the current X86_FEATURE_RETPOLINE as the common one and add a
> new X86_FEATURE_RETPOLINE_GENERIC which is selected by the generic/intel
> side. Little more churn, but clearer.

Ok, I just sent v2 without that. Will do a v3.

-Andi