From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934336AbeAJPom (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Wed, 10 Jan 2018 10:44:42 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56768 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932532AbeAJPol (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 10 Jan 2018 10:44:41 -0500
Date: Wed, 10 Jan 2018 16:44:38 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        David Ahern <dsahern@gmail.com>,
        Andi Kleen <ak@linux.intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: Re: [PATCH 09/12] perf script: Add support to display lost events
Message-ID: <20180110154438.GA20000@krava>
References: <20180107160356.28203-1-jolsa@kernel.org>
 <20180107160356.28203-10-jolsa@kernel.org>
 <20180110154050.GA20090@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180110154050.GA20090@kernel.org>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 10 Jan 2018 15:44:41 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Wed, Jan 10, 2018 at 12:40:50PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sun, Jan 07, 2018 at 05:03:53PM +0100, Jiri Olsa escreveu:
> > +++ b/tools/perf/util/event.c
> > +static size_t perf_event__fprintf_lost(union perf_event *event, FILE *fp)
> > +{
> > +	return fprintf(fp, " lost %lu\n", event->lost.lost);
> > +}
> 
> Had to make this:
> 
> 	return fprintf(fp, " lost %" PRIu64 "\n", event->lost.lost);

right, thanks

jirka

> 
> To fix this:
> 
>   CC       /tmp/build/perf/util/event.o
> util/event.c: In function 'perf_event__fprintf_lost':
> util/event.c:1440:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'u64 {aka long long unsigned int}' [-Werror=format=]
>   return fprintf(fp, " lost %lu\n", event->lost.lost);
>                      ^
>   CC       /tmp/build/perf/builtin-script.o
>   CC       /tmp/build/perf/builtin-kmem.o
> cc1: all warnings being treated as errors
> 
>  on these systems:
> 
>   17 debian:experimental-x-mips  : FAIL mips-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
>   19 debian:experimental-x-mipsel: FAIL mipsel-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
>   25 fedora:24-x-ARC-uClibc      : FAIL arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710
>   43 ubuntu:16.04-x-arm          : FAIL arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
>   45 ubuntu:16.04-x-powerpc      : FAIL powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
> 
> - Arnaldo