From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752681AbeAJV1O (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Wed, 10 Jan 2018 16:27:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:53776 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750718AbeAJV1N (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 10 Jan 2018 16:27:13 -0500
Date: Wed, 10 Jan 2018 15:27:10 -0600
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
        Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andi Kleen <andi@firstfloor.org>,
        the arch/x86 maintainers <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Paul Turner <pjt@google.com>,
        Andrew Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linux-foundation.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Jiri Kosina <jikos@kernel.org>, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] x86/alternatives: Fix optimize_nops() checking
Message-ID: <20180110212710.en5ukccrw4sb7klt@treble>
References: <20180110112815.mgciyf5acwacphkq@pd.tnic>
 <CA+55aFz=yU7Q87ooyokssaFEGBx8BL+Vzs=4z+OOzvg-K5tfbA@mail.gmail.com>
 <alpine.DEB.2.20.1801102053120.1919@nanos>
 <20180110201532.5jnji6ypfl6slzvb@treble>
 <CA+55aFzMzBwtfO1e=eC6oCx9mMMXPoRko0FvKKJrriUGqyQtEg@mail.gmail.com>
 <20180110205544.k2e534nkk27lkpjc@pd.tnic>
 <CA+55aFykL6+9kJjP2J-y3D7h7s3KhASVJ_cULa12zk5o37=OsA@mail.gmail.com>
 <1515618537.22302.253.camel@infradead.org>
 <CA+55aFxOArsmQqu5B9GZY3c662T-dDEUU1e152GoyXY4Lr3V8A@mail.gmail.com>
 <CA+55aFxv5hWTTUrQr+zVBovkL7_A9U5x07kxwdK3KGW5Ks9r2g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CA+55aFxv5hWTTUrQr+zVBovkL7_A9U5x07kxwdK3KGW5Ks9r2g@mail.gmail.com>
User-Agent: Mutt/1.6.0.1 (2016-04-01)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 10 Jan 2018 21:27:13 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Wed, Jan 10, 2018 at 01:17:45PM -0800, Linus Torvalds wrote:
> On Wed, Jan 10, 2018 at 1:11 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Wouldn't it be much better to simply do it as part of relocation instead?
> 
> .. except we only do real relocation for modules, and depend on the
> linker doing everything for us (handle_relocations() at load-time) I
> think.
> 
> So it's somewhat more involved surgery. Which explains the hack.
> 
> Nasty.

Right.  With KASLR, the relocations seem to be resolved by
handle_relocations(), but without KASLR, they're resolved in vmlinux
linking.

-- 
Josh