Hi, On Thu, Jan 11, 2018 at 07:34:12PM +0800, hao_zhang wrote: > This patch add pwm node for r40. > > Signed-off-by: hao_zhang > --- > arch/arm/boot/dts/sun8i-r40.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi > index 173dcc1..84c963c 100644 > --- a/arch/arm/boot/dts/sun8i-r40.dtsi > +++ b/arch/arm/boot/dts/sun8i-r40.dtsi > @@ -295,6 +295,11 @@ > bias-pull-up; > }; > > + pwm_pins: pwm-pins { > + pins = "PB2", "PB3"; > + function = "pwm"; > + }; > + Is it the only combination of pins that is usable? If so, you can add the pinctrl-0 property directly in the pwm nodes. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com