From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] elf: fix NT_FILE integer overflow
Date: Fri, 12 Jan 2018 14:52:08 -0800 [thread overview]
Message-ID: <20180112145208.b054caf00c6fa666cc1a1c9c@linux-foundation.org> (raw)
In-Reply-To: <20180112203427.GA9109@avx2>
On Fri, 12 Jan 2018 23:34:27 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> If vm.max_map_count bumped above 2^26 (67+ mil) and system has enough
> RAM to allocate all the VMAs (~12.8 GB on Fedora 27 with 200-byte VMAs),
> then it should be possible to overflow 32-bit "size", pass paranoia check,
> allocate very little vmalloc space and oops while writing into vmalloc
> guard page...
>
> But I didn't test this, only coredump of regular process.
>
> ...
>
> --- a/fs/binfmt_elf.c
> +++ b/fs/binfmt_elf.c
> @@ -1599,6 +1599,8 @@ static int fill_files_note(struct memelfnote *note)
>
> /* *Estimated* file count and total data size needed */
> count = current->mm->map_count;
> + if (count > UINT_MAX / 64)
> + return -EINVAL;
> size = count * 64;
>
> names_ofs = (2 + 3 * count) * sizeof(data[0]);
Why not make `size' a ulong (or size_t)? That seems to be the
appropriate type and the code will then immediately barf over the
MAX_FILE_NOTE_SIZE comparison anyway.
next prev parent reply other threads:[~2018-01-12 22:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 20:34 [PATCH] elf: fix NT_FILE integer overflow Alexey Dobriyan
2018-01-12 22:52 ` Andrew Morton [this message]
2018-01-13 9:14 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112145208.b054caf00c6fa666cc1a1c9c@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).