From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
David Ahern <dsahern@gmail.com>, Andi Kleen <ak@linux.intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: Re: [PATCH] perf tools: Fix copyfile_offset update of output offset
Date: Fri, 12 Jan 2018 16:46:28 -0300 [thread overview]
Message-ID: <20180112194628.GG9655@kernel.org> (raw)
In-Reply-To: <20180109133923.25406-1-jolsa@kernel.org>
Em Tue, Jan 09, 2018 at 02:39:23PM +0100, Jiri Olsa escreveu:
> We need to increase output offset in each iteration,
> not decrease it as we currently do.
>
> I guess we were lucky to finish in most cases in first
> iteration, so the bug never showed. However it shows a
> lot when working with big (~4GB) size data.
Try adding these in the future:
Fixes: 9c9f5a2f1944 ("perf tools: Introduce copyfile_offset() function")
Probably there are people tracking those to apply to older kernels :-)
- Arnaldo
> Link: http://lkml.kernel.org/n/tip-f4az7t2nxjbjz5tqrv83z64e@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> tools/perf/util/util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
> index a789f952b3e9..443892dabedb 100644
> --- a/tools/perf/util/util.c
> +++ b/tools/perf/util/util.c
> @@ -210,7 +210,7 @@ static int copyfile_offset(int ifd, loff_t off_in, int ofd, loff_t off_out, u64
>
> size -= ret;
> off_in += ret;
> - off_out -= ret;
> + off_out += ret;
> }
> munmap(ptr, off_in + size);
>
> --
> 2.13.6
next prev parent reply other threads:[~2018-01-12 19:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 13:39 [PATCH] perf tools: Fix copyfile_offset update of output offset Jiri Olsa
2018-01-12 19:46 ` Arnaldo Carvalho de Melo [this message]
2018-01-17 16:26 ` [tip:perf/core] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112194628.GG9655@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).