From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755204AbeAMOxD (ORCPT + 1 other); Sat, 13 Jan 2018 09:53:03 -0500 Received: from one.firstfloor.org ([193.170.194.197]:40790 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755174AbeAMOxB (ORCPT ); Sat, 13 Jan 2018 09:53:01 -0500 Date: Sat, 13 Jan 2018 06:53:00 -0800 From: Andi Kleen To: Greg KH Cc: Andi Kleen , tglx@linutronix.de, dwmw@amazon.co.uk, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, arjan.van.de.ven@intel.com, peterz@infradead.org, Andi Kleen , jeyu@kernel.org Subject: Re: [PATCH] retpoline/module: Taint kernel for missing retpoline in module Message-ID: <20180113145259.ofw2u656h4awdyzw@two.firstfloor.org> References: <20180112175507.31750-1-andi@firstfloor.org> <20180113141209.GA13015@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180113141209.GA13015@kroah.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > > When the a module hasn't been compiled with a retpoline > > aware compiler, print a warning and set a taint flag. > > Isn't that caught by the "build with a different compiler/version" check > that we have? Or used to have? If not, can't we just make it into that - the compiler version number may not change if a distribution backports the gcc changes for the new flag - the module might be using a custom make file that does not correctly set the flag, even if the compiler supports it > type of check to catch this type of problem no matter what type of > feature/option it is trying to catch? I suspect that would be far more complicated. Also what's the point of putting this information into every symbol? Once per module is good enough. We already have similar checks for staging etc. -Andi