From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754082AbeAMSVA (ORCPT + 1 other); Sat, 13 Jan 2018 13:21:00 -0500 Received: from one.firstfloor.org ([193.170.194.197]:45118 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752673AbeAMSU7 (ORCPT ); Sat, 13 Jan 2018 13:20:59 -0500 Date: Sat, 13 Jan 2018 10:20:58 -0800 From: Andi Kleen To: Greg KH Cc: Andi Kleen , tglx@linutronix.de, dwmw@amazon.co.uk, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, arjan.van.de.ven@intel.com, peterz@infradead.org, Andi Kleen , jeyu@kernel.org Subject: Re: [PATCH] retpoline/module: Taint kernel for missing retpoline in module Message-ID: <20180113182057.447f2cqnp75olo7z@two.firstfloor.org> References: <20180112175507.31750-1-andi@firstfloor.org> <20180113141209.GA13015@kroah.com> <20180113145259.ofw2u656h4awdyzw@two.firstfloor.org> <20180113153644.GA25956@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180113153644.GA25956@kroah.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > > Also what's the point of putting this information into every symbol? > > It makes it easy to check :) Easier than nm? Per symbol still doesn't make any sense to me. > > > Once per module is good enough. > > > > We already have similar checks for staging etc. > > Sure, but this is more of a "Hey, your version of GCC is doing something > different than what you built the kernel with, watch out!" which is much > more generic and good to know. A whole taint for one CPU bug type seems > overkill to me. I removed the taint in version 2, posted yesterday. It now just prints the warning and resets the vulnerability reporting in sysfs. -Andi