From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753170AbeAMTwO (ORCPT + 1 other); Sat, 13 Jan 2018 14:52:14 -0500 Received: from mail-pl0-f66.google.com ([209.85.160.66]:43041 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbeAMTwN (ORCPT ); Sat, 13 Jan 2018 14:52:13 -0500 X-Google-Smtp-Source: ACJfBovRJKoINaGr9cbZYRwV0lUtC6f33GmVT67CW0N0hZNxNxSQfTcTjpNj7YgFtzJQHMSx7gEhAA== Date: Sun, 14 Jan 2018 01:22:05 +0530 From: Himanshu Jha To: Fabio Estevam Cc: Masahiro Yamada , michal.lkml@markovi.net, nicolas.palix@imag.fr, linux-kernel , cocci@systeme.lip6.fr Subject: Re: [Cocci] [PATCH] Coccinelle: kzalloc-simple: Rename kzalloc-simple to zalloc-simple Message-ID: <20180113195205.GB6389@himanshu-Vostro-3559> References: <1515859050-31764-1-git-send-email-himanshujha199640@gmail.com> <20180113175353.GA3513@himanshu-Vostro-3559> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Sat, Jan 13, 2018 at 05:13:36PM -0200, Fabio Estevam wrote: > On Sat, Jan 13, 2018 at 3:53 PM, Himanshu Jha > wrote: > > > Yes, I used 'git mv'. > > > > It doesn't matter when applying through 'git am', both will result the > > same AFAIK and only difference is that the patch files generated by 'git > > format-patch' are different. But that is not important I think. > > You missed the -M option when running 'git format'. > > For reviewers it is not that easy to realize that the 448 lines of the > original file are the same as the ones in the new file. > > The -M option generates a much cleaner patch. I guess you're right because patch has many lines. No problem, I will send again with a much cleaner patch. :-) -- Thanks Himanshu Jha