From: Bjorn Helgaas <helgaas@kernel.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: pci/setup-bus: Delete an error message for a failed memory allocation in add_to_list()
Date: Sat, 13 Jan 2018 14:17:09 -0600 [thread overview]
Message-ID: <20180113201709.GF205469@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <03f4a55c-3bc3-0f15-bfc4-73049861edc4@users.sourceforge.net>
On Sat, Jan 13, 2018 at 07:15:04AM +0100, SF Markus Elfring wrote:
> >> Omit an extra message for a memory allocation failure in this function.
> >
> > If this is an "extra" message, I assume there's some other message?
> > Can you mention where that is in the changelog?
>
> * Would you like to get a more detailed commit description?
Your commit message says "omit an extra message", which suggests that
there are currently two messages about the memory allocation failure,
and that your patch removes one of them.
If that's the case, it would be nice to know where the other message
is.
If your patch removes the *only* message about the memory allocation
failure, that might be worth doing, but the changelog should be clear
about that and say "I don't think the error message is worthwhile
because the function already returns failure" or something similar.
> * Are you looking for a reminder on the Linux allocation failure report?
I don't know what the "Linux allocation failure report" is.
> > Also, please squash all the drivers/pci patches into one.
>
> To which other change possibilities do you refer here?
You posted two patches that remove error messages about memory
allocation failures:
http://lkml.kernel.org/r/dc3922b4-50f6-e7fa-482f-18e6ff5d905f@users.sourceforge.net
http://lkml.kernel.org/r/fd9d212e-e8da-1aa7-be7f-7bf6d8f1e15f@users.sourceforge.net
These are doing the same thing and could be combined into one patch.
Bjorn
next prev parent reply other threads:[~2018-01-13 20:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 11:47 [PATCH] pci/setup-bus: Delete an error message for a failed memory allocation in add_to_list() SF Markus Elfring
2018-01-13 0:08 ` Bjorn Helgaas
2018-01-13 6:15 ` SF Markus Elfring
2018-01-13 20:17 ` Bjorn Helgaas [this message]
2018-01-13 21:08 ` SF Markus Elfring
2018-01-17 18:16 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180113201709.GF205469@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).