From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751947AbeANRA6 (ORCPT + 1 other); Sun, 14 Jan 2018 12:00:58 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:59306 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210AbeANRA4 (ORCPT ); Sun, 14 Jan 2018 12:00:56 -0500 Date: Sun, 14 Jan 2018 12:00:54 -0500 (EST) Message-Id: <20180114.120054.198827806177867676.davem@davemloft.net> To: arnd@arndb.de Cc: jaswinder.singh@linaro.org, ard.biesheuvel@linaro.org, weiyongjun1@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net-next] net: netsec: use dma_addr_t for storing dma address From: David Miller In-Reply-To: <20180113211355.638195-1-arnd@arndb.de> References: <20180113211355.638195-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 14 Jan 2018 09:00:56 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Arnd Bergmann Date: Sat, 13 Jan 2018 22:13:44 +0100 > On targets that have different sizes for phys_addr_t and dma_addr_t, > we get a type mismatch error: > > drivers/net/ethernet/socionext/netsec.c: In function 'netsec_alloc_dring': > drivers/net/ethernet/socionext/netsec.c:970:9: error: passing argument 3 of 'dma_zalloc_coherent' from incompatible pointer type [-Werror=incompatible-pointer-types] > > The code is otherwise correct, as the address is never actually used as a > physical address but only passed into a DMA register. For consistently, > I'm changing the variable name as well, to clarify that this is a DMA > address. > > Signed-off-by: Arnd Bergmann Applied, thanks Arnd.