From: Greg KH <greg@kroah.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Vince Weaver <vince@deater.net>,
torvalds@linux-foundation.org, robert@swiecki.net,
luto@amacapital.net, hughd@google.com,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: Re: [PATCH] x86,perf: Disable intel_bts when PTI
Date: Sun, 14 Jan 2018 14:27:28 +0100 [thread overview]
Message-ID: <20180114132728.GA3589@kroah.com> (raw)
In-Reply-To: <20180114125444.uqr53c6ryfn5hd53@gmail.com>
On Sun, Jan 14, 2018 at 01:54:44PM +0100, Ingo Molnar wrote:
>
> * Greg KH <greg@kroah.com> wrote:
>
> > On Sun, Jan 14, 2018 at 11:27:13AM +0100, Peter Zijlstra wrote:
> > >
> > > The intel_bts driver does not use the 'normal' BTS buffer we allocated
> > > space for in the cpu_entry_area but instead uses the memory allocated
> > > for the perf AUX buffer.
> > >
> > > This obviously comes apart when using PTI because then the kernel
> > > mapping; which includes that AUX buffer memory; disappears.
> > >
> > > For now disable this driver when PTI is enabled, we'll try and sort
> > > something out later.
> > >
> > > Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> > > Reported-by: Vince Weaver <vincent.weaver@maine.edu>
> > > Reported-by: Robert Święcki <robert@swiecki.net>
> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> >
> > Can you add a:
> > Cc: stable <stable@vger.kernel.org>
> > please?
>
> Note that these fixes are all going into tip:x86/pti, which is still a backporting
> friendly linear set of commits that should all be backported.
>
> So once 99a9dc98ba52 goes upstream, all of v4.14..99a9dc98ba52 the remaining bits
> can go to -stable as well.
>
> Will keep you updated about the latest status periodically, right now the latest
> that is already upstream is:
>
> de791821c295: x86/pti: Rename BUG_CPU_INSECURE to BUG_CPU_MELTDOWN
>
> i.e. all 194 commits in the v4.14..de791821c295 range should be queued up for
> -stable. (And most of them already are.)
I hope I got all of those in that branch already, as I've been watching
it :)
> There are 28 new commits in tip:x86/pti that will (hopefully) go upstream later
> today.
Great, again, thanks for doing it this way, it has made it much easier
for me.
greg k-h
prev parent reply other threads:[~2018-01-14 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 10:27 [PATCH] x86,perf: Disable intel_bts when PTI Peter Zijlstra
2018-01-14 10:46 ` [tip:x86/pti] " tip-bot for Peter Zijlstra
2018-01-14 10:50 ` [PATCH] " Greg KH
2018-01-14 10:52 ` Thomas Gleixner
2018-01-14 12:54 ` Ingo Molnar
2018-01-14 13:27 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180114132728.GA3589@kroah.com \
--to=greg@kroah.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=robert@swiecki.net \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).