From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030777AbeAOObe (ORCPT + 1 other); Mon, 15 Jan 2018 09:31:34 -0500 Received: from foss.arm.com ([217.140.101.70]:39648 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934270AbeAOMhF (ORCPT ); Mon, 15 Jan 2018 07:37:05 -0500 Date: Mon, 15 Jan 2018 12:36:58 +0000 From: Sudeep Holla To: Jeremy Linton Cc: linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, hanjun.guo@linaro.org, lorenzo.pieralisi@arm.com, rjw@rjwysocki.net, will.deacon@arm.com, catalin.marinas@arm.com, gregkh@linuxfoundation.org, viresh.kumar@linaro.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, jhugo@codeaurora.org, wangxiongfeng2@huawei.com, Jonathan.Zhang@cavium.com, ahs3@redhat.com, Jayachandran.Nair@cavium.com, austinwc@codeaurora.org, lenb@kernel.org, vkilari@codeaurora.org, morten.rasmussen@arm.com, Palmer Dabbelt , Albert Ou , Sudeep Holla Subject: Re: [PATCH v6 03/12] cacheinfo: rename of_node to fw_unique Message-ID: <20180115123658.GC5473@e107155-lin> References: <20180113005920.28658-1-jeremy.linton@arm.com> <20180113005920.28658-4-jeremy.linton@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180113005920.28658-4-jeremy.linton@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Fri, Jan 12, 2018 at 06:59:11PM -0600, Jeremy Linton wrote: > Rename and change the type of of_node to indicate > it is a generic pointer which is generally only used > for comparison purposes. In a later patch we will apply > an ACPI/PPTT "token" pointer in fw_unique so that > the code which builds the shared cpu masks can be reused. > [Nit] as used in the commit log, I prefer fw_token over fw_unique. But I am fine if you/others prefer fw_unique. Otherwise, Acked-by: Sudeep Holla -- Regards, Sudeep