From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750837AbeAOXgr (ORCPT + 1 other); Mon, 15 Jan 2018 18:36:47 -0500 Received: from ozlabs.org ([103.22.144.67]:35057 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbeAOXgp (ORCPT ); Mon, 15 Jan 2018 18:36:45 -0500 Date: Tue, 16 Jan 2018 10:36:43 +1100 From: Stephen Rothwell To: David Miller , Networking Cc: Linux-Next Mailing List , Linux Kernel Mailing List , Mike Maloney Subject: linux-next: manual merge of the net-next tree with the net tree Message-ID: <20180116103643.56542126@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/ipv6/ip6_output.c between commit: 749439bfac6e ("ipv6: fix udpv6 sendmsg crash caused by too small MTU") from the net tree and commit: 0f6c480f23f4 ("xfrm: Move dst->path into struct xfrm_dst") from the net-next tree. I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. -- Cheers, Stephen Rothwell diff --cc net/ipv6/ip6_output.c index 4f7d8de56611,18547a44bdaf..000000000000 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@@ -1206,18 -1215,16 +1215,18 @@@ static int ip6_setup_cork(struct sock * v6_cork->tclass = ipc6->tclass; if (rt->dst.flags & DST_XFRM_TUNNEL) mtu = np->pmtudisc >= IPV6_PMTUDISC_PROBE ? - rt->dst.dev->mtu : dst_mtu(&rt->dst); + READ_ONCE(rt->dst.dev->mtu) : dst_mtu(&rt->dst); else mtu = np->pmtudisc >= IPV6_PMTUDISC_PROBE ? - READ_ONCE(rt->dst.dev->mtu) : dst_mtu(rt->dst.path); - rt->dst.dev->mtu : dst_mtu(xfrm_dst_path(&rt->dst)); ++ READ_ONCE(rt->dst.dev->mtu) : dst_mtu(xfrm_dst_path(&rt->dst)); if (np->frag_size < mtu) { if (np->frag_size) mtu = np->frag_size; } + if (mtu < IPV6_MIN_MTU) + return -EINVAL; cork->base.fragsize = mtu; - if (dst_allfrag(rt->dst.path)) + if (dst_allfrag(xfrm_dst_path(&rt->dst))) cork->base.flags |= IPCORK_ALLFRAG; cork->base.length = 0;