From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751441AbeAPPCV (ORCPT + 1 other); Tue, 16 Jan 2018 10:02:21 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:54782 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751371AbeAPPCR (ORCPT ); Tue, 16 Jan 2018 10:02:17 -0500 Date: Tue, 16 Jan 2018 16:02:17 +0100 From: Greg KH To: Arnd Bergmann Cc: Stephen Rothwell , Linux-Next Mailing List , Linux Kernel Mailing List , NeilBrown Subject: Re: linux-next: build warning after merge of the staging tree Message-ID: <20180116150217.GB27126@kroah.com> References: <20180116134544.5f999209@canb.auug.org.au> <20180116055901.GA20154@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 16, 2018 at 11:47:47AM +0100, Arnd Bergmann wrote: > On Tue, Jan 16, 2018 at 6:59 AM, Greg KH wrote: > > On Tue, Jan 16, 2018 at 01:45:44PM +1100, Stephen Rothwell wrote: > >> Hi Greg, > >> > >> After merging the staging tree, today's linux-next build (x86_64 > >> allmodconfig) produced this warning: > >> > >> drivers/staging/lustre/lnet/selftest/module.c: In function 'lnet_selftest_init': > >> drivers/staging/lustre/lnet/selftest/module.c:98:10: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized] > >> return rc; > >> ^~ > >> > >> Introduced by commit > >> > >> 6106c0f82481 ("staging: lustre: lnet: convert selftest to use workqueues") > > > > Yeah, I told Neil about this, hopefully he sends me a fix soon :) > > I sent a fix for that one, but now ran into another problem that I can't > easily figure out: > > drivers/staging/lustre/lnet/selftest/module.c: In function 'lnet_selftest_init': > drivers/staging/lustre/lnet/selftest/module.c:128:49: error: 'struct > cfs_cpt_table' has no member named 'ctb_parts'; did you mean > 'ctb_nparts'? > cpumask_copy(attrs.cpumask, lnet_cpt_table()->ctb_parts[i].cpt_cpumask); > > I see that there are two definitions of 'struct cfs_cpt_table', and only > one of them has a ctb_parts member, but I don't know what this means > for its users. > > The build regression also comes from commit 6106c0f82481 ("staging: > lustre: lnet: convert selftest to use workqueues"), and I see that all > other references to ctb_parts are in > drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c. Odd, I can't duplicate the build error here, but 0-day also complains about this. Neil is out until Friday, so maybe he can fix it up then... thanks, greg k-h