From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753062AbeARBV0 (ORCPT ); Wed, 17 Jan 2018 20:21:26 -0500 Received: from mail.cn.fujitsu.com ([183.91.158.132]:14548 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752588AbeARBVZ (ORCPT ); Wed, 17 Jan 2018 20:21:25 -0500 X-IronPort-AV: E=Sophos;i="5.43,368,1503331200"; d="scan'208";a="35427167" Date: Thu, 18 Jan 2018 09:20:01 +0800 From: Chao Fan To: Baoquan He CC: , , , , , , , , Subject: Re: [PATCH v7 3/5] x86/KASLR: Give a warning if movable_node specified without kaslr_mem= Message-ID: <20180118012001.GC24593@localhost.localdomain> References: <20180117105351.12226-1-fanc.fnst@cn.fujitsu.com> <20180117105351.12226-4-fanc.fnst@cn.fujitsu.com> <20180117140248.GG2321@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20180117140248.GG2321@localhost.localdomain> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [10.167.225.56] X-yoursite-MailScanner-ID: 5BBC3486A76B.ABB81 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: fanc.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 17, 2018 at 10:02:48PM +0800, Baoquan He wrote: >On 01/17/18 at 06:53pm, Chao Fan wrote: >> Since only 'movable_node' specified without 'kaslr_mem=' may break >> memory hotplug, so reconmmend users using 'kaslr_mem=' when >> 'movable_node' specified.. >> >> Signed-off-by: Chao Fan >> --- >> arch/x86/boot/compressed/kaslr.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c >> index b200a7ceafc1..dca846b522fc 100644 >> --- a/arch/x86/boot/compressed/kaslr.c >> +++ b/arch/x86/boot/compressed/kaslr.c >> @@ -282,6 +282,16 @@ static int handle_mem_filter(void) >> !strstr(args, "kaslr_mem=")) >> return 0; >> >> +#ifdef CONFIG_MEMORY_HOTPLUG >> + /* >> + * Check if "kaslr_mem=" specified when "movable_node" found. If not, >> + * just give warrning. Otherwise memory hotplug could be >> + * affected if kernel put on movable memory regions. >> + */ >> + if (strstr(args, "movable_node") && !strstr(args, "kaslr_mem=")) >> + warn("kaslr_mem= should specified when using movable_node.\n"); > 'kaslr_mem=' ^be You have given me a large help for my poor English. Thanks, Chao Fan >> +#endif >> + >> tmp_cmdline = malloc(len + 1); >> if (!tmp_cmdline) >> error("Failed to allocate space for tmp_cmdline"); >> -- >> 2.14.3 >> >> >> > >