From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933237AbeARQKK (ORCPT <rfc822;w@1wt.eu>);
        Thu, 18 Jan 2018 11:10:10 -0500
Received: from bombadil.infradead.org ([65.50.211.133]:58183 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755289AbeARQJx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 18 Jan 2018 11:09:53 -0500
Date: Thu, 18 Jan 2018 07:45:13 -0800
From: Christoph Hellwig <hch@infradead.org>
To: Palmer Dabbelt <palmer@sifive.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Christoph Hellwig <hch@infradead.org>,
        linux-kernel@vger.kernel.org, patches@groups.riscv.org,
        Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH 1/2] asm-generic: Add a generic set_handle_irq
Message-ID: <20180118154513.GA2678@infradead.org>
References: <20180118154005.24994-1-palmer@sifive.com>
 <20180118154005.24994-2-palmer@sifive.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180118154005.24994-2-palmer@sifive.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I think this should not be asm-generic and lib, but kernel/irq/handle.c
and include/linux/irq.h, under the CONFIG_MULTI_IRQ_HANDLER symbol
already used by arm.

Also for completeness of the series please convert arm, arm64 and
openrisc over to the generic version.  Last but not least I think
handle_arch_irq needs to be marked as __ro_after_init as a security
hardening measure.