From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756139AbeASQQl (ORCPT <rfc822;w@1wt.eu>);
        Fri, 19 Jan 2018 11:16:41 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:43060 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755744AbeASQQc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 19 Jan 2018 11:16:32 -0500
Date: Fri, 19 Jan 2018 11:16:25 -0500 (EST)
Message-Id: <20180119.111625.1700179370745007835.davem@davemloft.net>
To: frederic@kernel.org
Cc: linux-kernel@vger.kernel.org, alexander.levin@verizon.com,
        peterz@infradead.org, mchehab@s-opensource.com,
        torvalds@linux-foundation.org, hannes@stressinduktion.org,
        paulmck@linux.vnet.ibm.com, wanpeng.li@hotmail.com, dima@arista.com,
        tglx@linutronix.de, akpm@linux-foundation.org, pabeni@redhat.com,
        rrendec@arista.com, mingo@kernel.org, sgruszka@redhat.com,
        riel@redhat.com, edumazet@google.com
Subject: Re: [RFC PATCH 1/4] softirq: Limit vector to a single iteration on
 IRQ tail
From: David Miller <davem@davemloft.net>
In-Reply-To: <1516376774-24076-2-git-send-email-frederic@kernel.org>
References: <1516376774-24076-1-git-send-email-frederic@kernel.org>
        <1516376774-24076-2-git-send-email-frederic@kernel.org>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Frederic Weisbecker <frederic@kernel.org>
Date: Fri, 19 Jan 2018 16:46:11 +0100

> For now, vectors that get re-enqueued trigger ksoftirqd but they are
> going to be handled by per-vector workqueues on subsequent patches.

Frederic, first of all, thanks for doing all of this work.

So this "get requeued" condition I think will trigger always for
networking tunnel decapsulation.

Each decap will (eventually) do a:

	__raise_softirq_irqoff(NET_RX_SOFTIRQ);

via ____napi_schedule() in net/core/dev.c

Example code path:

	ip_tunnel_rcv()
		gro_cells_receive()
			napi_schedule()
			__napi_schedule()
				____napi_schedule();
				__raise_softirq_irqoff(NET_RX_SOFTIRQ);

Anyways, just FYI...