* [PATCH][next] mlxsw: spectrum: make function mlxsw_sp_kvdl_part_occ static
@ 2018-01-17 10:57 Colin King
2018-01-19 19:36 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-01-17 10:57 UTC (permalink / raw)
To: Jiri Pirko, Ido Schimmel, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function mlxsw_sp_kvdl_part_occ is local to the source and does
not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'mlxsw_sp_kvdl_part_occ' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c
index cfacc176a1bd..55f9d2d70f9e 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c
@@ -286,7 +286,7 @@ static void mlxsw_sp_kvdl_parts_fini(struct mlxsw_sp *mlxsw_sp)
mlxsw_sp_kvdl_part_fini(mlxsw_sp, i);
}
-u64 mlxsw_sp_kvdl_part_occ(struct mlxsw_sp_kvdl_part *part)
+static u64 mlxsw_sp_kvdl_part_occ(struct mlxsw_sp_kvdl_part *part)
{
unsigned int nr_entries;
int bit = -1;
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] mlxsw: spectrum: make function mlxsw_sp_kvdl_part_occ static
2018-01-17 10:57 [PATCH][next] mlxsw: spectrum: make function mlxsw_sp_kvdl_part_occ static Colin King
@ 2018-01-19 19:36 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-01-19 19:36 UTC (permalink / raw)
To: colin.king; +Cc: jiri, idosch, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Wed, 17 Jan 2018 10:57:46 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> The function mlxsw_sp_kvdl_part_occ is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'mlxsw_sp_kvdl_part_occ' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks Colin.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-19 19:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-17 10:57 [PATCH][next] mlxsw: spectrum: make function mlxsw_sp_kvdl_part_occ static Colin King
2018-01-19 19:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).