From: Jiri Olsa <jolsa@redhat.com>
To: Wang YanQing <udknight@gmail.com>,
acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf report: Provide libtraceevent with a kernel symbol resolver
Date: Fri, 19 Jan 2018 19:57:59 +0100 [thread overview]
Message-ID: <20180119185759.GA24243@krava> (raw)
In-Reply-To: <20180118142230.GA5078@udknight>
On Thu, Jan 18, 2018 at 10:22:30PM +0800, Wang YanQing wrote:
> On Thu, Jan 18, 2018 at 10:43:18AM +0100, Jiri Olsa wrote:
> > On Wed, Jan 17, 2018 at 12:48:12AM +0800, Wang YanQing wrote:
> > > On Mon, Jan 15, 2018 at 11:06:11AM +0100, Jiri Olsa wrote:
> > > > On Mon, Jan 15, 2018 at 12:47:32PM +0800, Wang YanQing wrote:
> > > > > So that beautifiers wanting to resolve kernel function addresses to
> > > > > names can do its work, and when we use "perf report" for output of
> > > > > "perf kmem record", we will get kernel symbol output.
> > > > >
> > > > > Signed-off-by: Wang YanQing <udknight@gmail.com>
> > > > > ---
> > > > > tools/perf/builtin-report.c | 9 +++++++++
> > > > > 1 file changed, 9 insertions(+)
> > > > >
> > > > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> > > > > index dd4df9a..7b65100 100644
> > > > > --- a/tools/perf/builtin-report.c
> > > > > +++ b/tools/perf/builtin-report.c
> > > > > @@ -1317,6 +1317,15 @@ int cmd_report(int argc, const char **argv)
> > > > > report.range_num = 1;
> > > > > }
> > > > >
> > > > > + if (session->tevent.pevent &&
> > > > > + pevent_set_function_resolver(session->tevent.pevent,
> > > > > + machine__resolve_kernel_addr,
> > > > > + &session->machines.host) < 0) {
> > > > > + pr_err("%s: failed to set libtraceevent function resolver\n",
> > > > > + __func__);
> > > > > + return -1;
> > > > > + }
> > > >
> > > > why not calling the wrapper trace_event__register_resolver?
> > > The reason is the same as builtin-script doesn't use trace_event__register_resolver,
> > > because we only use report and script to analyze offline perf.data, and there could
> > > be no tracepoints in perf.data.
> >
> > hum, I missed this functionality.. so we need this even if there
> > are no tracepoints in the perf.data?
>
> In "perf report", when there are tracepoints in perf.data, session->tevent.pevent
> will be initialized in trace-event-read.c:trace_report, then "if (session->tevent.pevent"
> will become true, and we should calling pevent_set_function_resolver.
>
> But if we calling trace_event__register_resolver, then it will initialize tevent.pevent
> no matter whether there are tracepoints in perf.data.
ok, should we call it from perf_session__read_header then?
below perf_evlist__prepare_tracepoint_events perhaps
jirka
next prev parent reply other threads:[~2018-01-19 18:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 4:47 [PATCH] perf report: Provide libtraceevent with a kernel symbol resolver Wang YanQing
2018-01-15 10:06 ` Jiri Olsa
2018-01-16 16:48 ` Wang YanQing
2018-01-18 9:43 ` Jiri Olsa
2018-01-18 14:22 ` Wang YanQing
2018-01-19 18:57 ` Jiri Olsa [this message]
2018-01-21 17:25 ` Wang YanQing
2018-01-23 12:41 ` Jiri Olsa
2018-02-08 12:20 ` Jiri Olsa
2018-03-06 7:36 ` Wang YanQing
2018-03-06 14:01 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119185759.GA24243@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).