linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] staging: android: ion: Zero CMA allocated memory
@ 2018-01-19 19:16 Liam Mark
  2018-01-19 20:14 ` Dan Carpenter
  2018-01-20  8:00 ` Greg KH
  0 siblings, 2 replies; 5+ messages in thread
From: Liam Mark @ 2018-01-19 19:16 UTC (permalink / raw)
  To: Laura Abbott, Sumit Semwal; +Cc: linaro-mm-sig, devel, linux-kernel

Since the CMA API is now used directly the allocated memory is no longer
automatically zeroed.

Explicitly zero CMA allocated memory to ensure that no data is exposed
to userspace.

Change-Id: I08e143707a0d31610821a7f16826c262bf3c1999
Signed-off-by: Liam Mark <lmark@codeaurora.org>
---
 drivers/staging/android/ion/ion_cma_heap.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
index 86196ff..91a9878 100644
--- a/drivers/staging/android/ion/ion_cma_heap.c
+++ b/drivers/staging/android/ion/ion_cma_heap.c
@@ -51,6 +51,8 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
 	if (!pages)
 		return -ENOMEM;
 
+	memset(page_address(pages), 0, size);
+
 	table = kmalloc(sizeof(*table), GFP_KERNEL);
 	if (!table)
 		goto err;
-- 
1.8.5.2


Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] staging: android: ion: Zero CMA allocated memory
  2018-01-19 19:16 [PATCH] staging: android: ion: Zero CMA allocated memory Liam Mark
@ 2018-01-19 20:14 ` Dan Carpenter
  2018-01-22 16:48   ` Liam Mark
  2018-01-20  8:00 ` Greg KH
  1 sibling, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2018-01-19 20:14 UTC (permalink / raw)
  To: Liam Mark; +Cc: linaro-mm-sig, devel, Sumit Semwal, linux-kernel

On Fri, Jan 19, 2018 at 11:16:47AM -0800, Liam Mark wrote:
> Since the CMA API is now used directly the allocated memory is no longer
> automatically zeroed.
> 
> Explicitly zero CMA allocated memory to ensure that no data is exposed
> to userspace.
> 
> Change-Id: I08e143707a0d31610821a7f16826c262bf3c1999

How do I use this Gerrit tag?  I type it into
https://android-review.googlesource.com/ somewhere?

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] staging: android: ion: Zero CMA allocated memory
  2018-01-19 19:16 [PATCH] staging: android: ion: Zero CMA allocated memory Liam Mark
  2018-01-19 20:14 ` Dan Carpenter
@ 2018-01-20  8:00 ` Greg KH
  2018-01-22 16:52   ` Liam Mark
  1 sibling, 1 reply; 5+ messages in thread
From: Greg KH @ 2018-01-20  8:00 UTC (permalink / raw)
  To: Liam Mark; +Cc: linaro-mm-sig, devel, Sumit Semwal, linux-kernel

On Fri, Jan 19, 2018 at 11:16:47AM -0800, Liam Mark wrote:
> Since the CMA API is now used directly the allocated memory is no longer
> automatically zeroed.
> 
> Explicitly zero CMA allocated memory to ensure that no data is exposed
> to userspace.

How far back does this patch need to be ported?  What is the git commit
id that caused this change to be needed?  Please add it as a "Fixes:"
tag to the patch.

> 
> Change-Id: I08e143707a0d31610821a7f16826c262bf3c1999

I'm guessing you didn't run scripts/checkpatch.pl on this patch :(

Please fix up and resend.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] staging: android: ion: Zero CMA allocated memory
  2018-01-19 20:14 ` Dan Carpenter
@ 2018-01-22 16:48   ` Liam Mark
  0 siblings, 0 replies; 5+ messages in thread
From: Liam Mark @ 2018-01-22 16:48 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: linaro-mm-sig, devel, Sumit Semwal, linux-kernel

[-- Attachment #1: Type: TEXT/PLAIN, Size: 643 bytes --]

On Fri, 19 Jan 2018, Dan Carpenter wrote:

> On Fri, Jan 19, 2018 at 11:16:47AM -0800, Liam Mark wrote:
> > Since the CMA API is now used directly the allocated memory is no longer
> > automatically zeroed.
> > 
> > Explicitly zero CMA allocated memory to ensure that no data is exposed
> > to userspace.
> > 
> > Change-Id: I08e143707a0d31610821a7f16826c262bf3c1999
> 
> How do I use this Gerrit tag?  I type it into
> https://android-review.googlesource.com/ somewhere?

Sorry, this tag won’t be any use to you, I will strip it out.

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[-- Attachment #2: Type: text/plain, Size: 169 bytes --]

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] staging: android: ion: Zero CMA allocated memory
  2018-01-20  8:00 ` Greg KH
@ 2018-01-22 16:52   ` Liam Mark
  0 siblings, 0 replies; 5+ messages in thread
From: Liam Mark @ 2018-01-22 16:52 UTC (permalink / raw)
  To: Greg KH; +Cc: Laura Abbott, Sumit Semwal, linaro-mm-sig, devel, linux-kernel

On Sat, 20 Jan 2018, Greg KH wrote:

> On Fri, Jan 19, 2018 at 11:16:47AM -0800, Liam Mark wrote:
> > Since the CMA API is now used directly the allocated memory is no longer
> > automatically zeroed.
> > 
> > Explicitly zero CMA allocated memory to ensure that no data is exposed
> > to userspace.
> 
> How far back does this patch need to be ported?  What is the git commit
> id that caused this change to be needed?  Please add it as a "Fixes:"
> tag to the patch.
> 

It goes back to 204f672255c2 ("ion: Use CMA APIs directly"), I will update 
the change.

> > 
> > Change-Id: I08e143707a0d31610821a7f16826c262bf3c1999
> 
> I'm guessing you didn't run scripts/checkpatch.pl on this patch :(
> 
> Please fix up and resend.

Thanks, I will clean it up.

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-22 16:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-19 19:16 [PATCH] staging: android: ion: Zero CMA allocated memory Liam Mark
2018-01-19 20:14 ` Dan Carpenter
2018-01-22 16:48   ` Liam Mark
2018-01-20  8:00 ` Greg KH
2018-01-22 16:52   ` Liam Mark

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).