From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756535AbeASUro (ORCPT ); Fri, 19 Jan 2018 15:47:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42020 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756473AbeASUrW (ORCPT ); Fri, 19 Jan 2018 15:47:22 -0500 From: Hans de Goede To: Darren Hart , Andy Shevchenko Cc: Hans de Goede , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] platform/x86: GPD pocket fan: Stop work on suspend Date: Fri, 19 Jan 2018 21:47:09 +0100 Message-Id: <20180119204709.16240-3-hdegoede@redhat.com> In-Reply-To: <20180119204709.16240-1-hdegoede@redhat.com> References: <20180119204709.16240-1-hdegoede@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stop the work on suspend, otherwise it may run between our suspend method running and the system suspending, possibly restarting the fan which we've just stopped. Note we already requeue the work on resume, so that we get a fresh speed at resume. Signed-off-by: Hans de Goede --- drivers/platform/x86/gpd-pocket-fan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/gpd-pocket-fan.c b/drivers/platform/x86/gpd-pocket-fan.c index f7b4980c0aa6..6425c9b49caa 100644 --- a/drivers/platform/x86/gpd-pocket-fan.c +++ b/drivers/platform/x86/gpd-pocket-fan.c @@ -177,6 +177,7 @@ static int gpd_pocket_fan_suspend(struct device *dev) { struct gpd_pocket_fan_data *fan = dev_get_drvdata(dev); + cancel_delayed_work_sync(&fan->work); gpd_pocket_fan_set_speed(fan, gpd_pocket_fan_min_speed()); return 0; } -- 2.14.3