From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756709AbeASWjc (ORCPT ); Fri, 19 Jan 2018 17:39:32 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33288 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756655AbeASWjQ (ORCPT ); Fri, 19 Jan 2018 17:39:16 -0500 X-Google-Smtp-Source: AH8x227EJAaZhOZu2/EulTWwHMAIygD3iByeV7f3UQGFmTrQRH1WEGbVyBdHS8shaLY4sArZsAxJ1w== Date: Fri, 19 Jan 2018 14:39:12 -0800 From: Dmitry Torokhov To: Randy Dunlap Cc: Benjamin Tissoires , Hans de Goede , Lyude Paul , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7] Input: libps2 - use BIT() for bitmask constants Message-ID: <20180119223912.ifpgwt2kxmq7l7gs@dtor-ws> References: <20180119194111.185590-1-dmitry.torokhov@gmail.com> <20180119194111.185590-4-dmitry.torokhov@gmail.com> <2d0591a7-ccab-872f-d52d-c8adf51d4373@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2d0591a7-ccab-872f-d52d-c8adf51d4373@infradead.org> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 19, 2018 at 02:26:20PM -0800, Randy Dunlap wrote: > On 01/19/2018 11:41 AM, Dmitry Torokhov wrote: > > Let's explicitly document bit numbers with BIT() macro. > > > > Signed-off-by: Dmitry Torokhov > > Makes sense, but something should > #include Indeed, I'll add it, thanks. > > per Documentation/process/submit-checklist.rst Rule #1: > 1) If you use a facility then #include the file that defines/declares > that facility. Don't depend on other header files pulling in ones > that you use. > > > > --- > > include/linux/libps2.h | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/include/linux/libps2.h b/include/linux/libps2.h > > index 365c50b097ded..649295a5ff47d 100644 > > --- a/include/linux/libps2.h > > +++ b/include/linux/libps2.h > > @@ -20,11 +20,11 @@ > > #define PS2_RET_NAK 0xfe > > #define PS2_RET_ERR 0xfc > > > > -#define PS2_FLAG_ACK 1 /* Waiting for ACK/NAK */ > > -#define PS2_FLAG_CMD 2 /* Waiting for command to finish */ > > -#define PS2_FLAG_CMD1 4 /* Waiting for the first byte of command response */ > > -#define PS2_FLAG_WAITID 8 /* Command execiting is GET ID */ > > -#define PS2_FLAG_NAK 16 /* Last transmission was NAKed */ > > +#define PS2_FLAG_ACK BIT(0) /* Waiting for ACK/NAK */ > > +#define PS2_FLAG_CMD BIT(1) /* Waiting for a command to finish */ > > +#define PS2_FLAG_CMD1 BIT(2) /* Waiting for the first byte of command response */ > > +#define PS2_FLAG_WAITID BIT(3) /* Command executing is GET ID */ > > +#define PS2_FLAG_NAK BIT(4) /* Last transmission was NAKed */ > > > > struct ps2dev { > > struct serio *serio; > > > > > -- > ~Randy -- Dmitry