From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756457AbeATC2G (ORCPT ); Fri, 19 Jan 2018 21:28:06 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:39508 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756249AbeATC17 (ORCPT ); Fri, 19 Jan 2018 21:27:59 -0500 X-Google-Smtp-Source: AH8x224cWEq3SyFkkvMV/LIgdfIleF1prop6bnWCq3woeqGUynmGHrUijxFTKCWq85lrDDqxqsmzYw== Date: Fri, 19 Jan 2018 18:27:55 -0800 From: Alexei Starovoitov To: Daniel Borkmann Cc: Eric Leblond , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next 0/4] libbpf: add XDP binding support Message-ID: <20180120022753.psuzgzmxqaubh5t3@ast-mbp> References: <1516318537.24936.7.camel@regit.org> <20180118234332.28996-1-eric@regit.org> <2a008274-a09d-71ed-4c1e-5d7aa2bb8797@iogearbox.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2a008274-a09d-71ed-4c1e-5d7aa2bb8797@iogearbox.net> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 20, 2018 at 03:00:37AM +0100, Daniel Borkmann wrote: > On 01/19/2018 12:43 AM, Eric Leblond wrote: > > Hello, > > > > This patchset rebases the libbpf code on latest bpf-next code and addresses > > remarks by Daniel. > > Ok, I think it's a good start. We should later on clean up the > netlink handling code a bit, but that's all internal and can be > done in a second step. Applied to bpf-next, thanks Eric. Sorry, Eric, Daniel. I had to revert this patch set. It breaks build on systems where headers are not the most recent. Since libbpf is used by perf it has to be built cleanly on centos7 at least. The errors I got: bpf.c: In function ‘bpf_set_link_xdp_fd’: bpf.c:456:23: error: ‘SOL_NETLINK’ undeclared (first use in this function) if (setsockopt(sock, SOL_NETLINK, NETLINK_EXT_ACK, ^~~~~~~~~~~ bpf.c:456:23: note: each undeclared identifier is reported only once for each function it appears in bpf.c:456:36: error: ‘NETLINK_EXT_ACK’ undeclared (first use in this function) if (setsockopt(sock, SOL_NETLINK, NETLINK_EXT_ACK, ^~~~~~~~~~~~~~~ nlattr.c: In function ‘nla_dump_errormsg’: nlattr.c:152:34: error: ‘NLMSGERR_ATTR_MAX’ undeclared (first use in this function) struct nla_policy extack_policy[NLMSGERR_ATTR_MAX + 1] = {