From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227kOC5FjIb3/GthU+nnIySobdWOcl/63d9zMJF2KsiBBQ4KylKgpYSOMvfKdjUFU+WMMT76 ARC-Seal: i=1; a=rsa-sha256; t=1516610956; cv=none; d=google.com; s=arc-20160816; b=oWuOI12ToU7PtzHGc6CxhFJ1uPemaGK8QwPNs6MO0nfUf/VqlYQ9Uu6vUv9XUyZ3HH mCQOkKCFbifDeWq2MEgbW+zd7epZY5S2KYE0Sf0QhPSynLR45h8zkvliwhq4+ho81Qxu 7ZSSI6cPB7YekA7q0JYt3Rpp1/IytBqb3CXgMXj3GW/rHRmbKjiHzCuUMPe+byyrGcAA 6T1/f0ywoFAIMtVKrHcNXFSE4ATh1IfE+og/ww6jB8GqTF+eLYwWMWpPcFlhMJC0IS9n FyiqqP6ByYa5xBqpj7ersYc3Lhisy5Qmf7XLBcu636n+EKS7FEgHSaKQdm6vgThoPusR ZbBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=7uFKJZT+gBDpvdUGMe0ydDZsi1tAriBwcaoqhWXm3Rw=; b=ON313PzJwSsmQr+YtMxfsb9SN3zb3YsTdZB2LYpVzNTCzqK+0v4CBg4gNUVfxE6kps F/FbthRfPS5IEDsmbh8jMSgtDV18higl9xml1bSIRdV0ydwnn2232hyYow4L3SChCyvW 206FHwP3hV3YYBOXNxt3VZuY82/TQeLuPQNsWTVBr0RTnAjePCZhl5aB9+4oCbo74HYG Ixmyid+SAu/VXEk/feKObN428PTsUGSMdxPNudLnoZAFSKhL/PgicHliye7xWH63sMpi GftNlLM01mD8NHTVytw+o+XicKfeXehpaQZ7b9FuAwGtzcUnp5wbeoaG4mHdzcs1xLeu o55g== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Shuah Khan , Andrey Konovalov Subject: [PATCH 4.9 41/47] usbip: fix warning in vhci_hcd_probe/lockdep_init_map Date: Mon, 22 Jan 2018 09:45:52 +0100 Message-Id: <20180122083928.627543255@linuxfoundation.org> X-Mailer: git-send-email 2.16.0 In-Reply-To: <20180122083925.568134913@linuxfoundation.org> References: <20180122083925.568134913@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590281849656331577?= X-GMAIL-MSGID: =?utf-8?q?1590281849656331577?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shuah Khan commit 918b8ac55b6c809b70aa05c279087109584e393e upstream. vhci_hcd calls sysfs_create_group() with dynamically allocated sysfs attributes triggering the lock-class key not persistent warning. Call sysfs_attr_init() for dynamically allocated sysfs attributes to fix it. vhci_hcd vhci_hcd: USB/IP Virtual Host Controller vhci_hcd vhci_hcd: new USB bus registered, assigned bus number 2 BUG: key ffff88006a7e8d18 not in .data! ------------[ cut here ]------------ WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:3131 lockdep_init_map+0x60c/0x770 DEBUG_LOCKS_WARN_ON(1)[ 1.567044] Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.9.0-rc7+ #58 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 ffff88006bce6eb8 ffffffff81f96c8a ffffffff00000a02 1ffff1000d79cd6a ffffed000d79cd62 000000046bce6ed8 0000000041b58ab3 ffffffff8598af40 ffffffff81f969f8 0000000000000000 0000000041b58ab3 0000000000000200 Call Trace: [< inline >] __dump_stack lib/dump_stack.c:15 [] dump_stack+0x292/0x398 lib/dump_stack.c:51 [] __warn+0x19f/0x1e0 kernel/panic.c:550 [] warn_slowpath_fmt+0xc5/0x110 kernel/panic.c:565 [] lockdep_init_map+0x60c/0x770 kernel/locking/lockdep.c:3131 [] __kernfs_create_file+0x114/0x2a0 fs/kernfs/file.c:954 [] sysfs_add_file_mode_ns+0x225/0x520 fs/sysfs/file.c:305 [< inline >] create_files fs/sysfs/group.c:64 [] internal_create_group+0x239/0x8f0 fs/sysfs/group.c:134 [] sysfs_create_group+0x1f/0x30 fs/sysfs/group.c:156 [] vhci_start+0x5b4/0x7a0 drivers/usb/usbip/vhci_hcd.c:978 [] usb_add_hcd+0x8da/0x1c60 drivers/usb/core/hcd.c:2867 [] vhci_hcd_probe+0x97/0x130 drivers/usb/usbip/vhci_hcd.c:1103 --- --- ---[ end trace c33c7b202cf3aac8 ]--- Signed-off-by: Shuah Khan Reported-by: Andrey Konovalov Signed-off-by: Greg Kroah-Hartman --- drivers/usb/usbip/vhci_sysfs.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/usb/usbip/vhci_sysfs.c +++ b/drivers/usb/usbip/vhci_sysfs.c @@ -361,6 +361,7 @@ static void set_status_attr(int id) status->attr.attr.name = status->name; status->attr.attr.mode = S_IRUGO; status->attr.show = status_show; + sysfs_attr_init(&status->attr.attr); } static int init_status_attrs(void)