From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3634966-1516704352-2-5763611540557211762 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.138', Host='smtp1.osuosl.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516704351; b=gMK92syJ9yeGXecGYKU1njAtce0I1ChMxmU2cvS7Iur7mUh gzDtyMvYm1U4lDgfHkNX8eAas2SC2d0NGgk6oZqcsLdXc5yd6W2dKLzkbXg1Tn8F v9P5SjbsrV1KAmzOm5HNiP/lA7emHfDQLAalbJZJrE7iUtgZ+oxhFMPIqCt2+RY/ mWmr1+f/vsqgevKSJ7RaRUf13ihvaVsufwz+WHVJMDWoHdvIKGYSwSSnkpUk5FTN SFnIaS4N2hHpaNeCRW/g+ytsbc2tol5b81rQeftVYe4qLDKLopq5M+x/3zonc+zJ 3NHruXzuU0e7vLxIRzNzIZFfEuUIQ87xmUAMB8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1516704351; bh=Y HxuEum8IIO3P9IRZ0v3/H3eHo4jUCDDKpfgA1KMoZA=; b=Dj3nKnqIGEa8VorrY s7bK+NWozdcwr4/MpS5cr8v0tfwHnY/cTENjPYrQK/MJpzXNbq8fLMF0fW+xkBPl KnFC61yOk1tTLKhhS+9/BhoQbabmgif+xogK3Yc4N0IAa6/XUfocYf7aLfKgEEkt McK0CHAyiJbjDXVszrD3t6xbx3QJcyR+2R2YjLrMjnshVI5PbzINLHH6P1yc7wTB JcvKqq4L+L8WxwGBeKvpGfNoNdwLqcI2aWXOzkUJrmH0zuUjMQUD3Hd8fTQvqc6w QgnUZ4QRnK93buReClu+FYkt8/d0tFiSvJQYwJz636FeDYfUxFBKGK2IDMF1/QjN 0EaaQ== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org Date: Tue, 23 Jan 2018 11:45:44 +0100 From: Greg KH To: Shreeya Patel Subject: Re: [PATCH v3 2/4] Staging: rtl8723bs: Change names to conform to the kernel code Message-ID: <20180123104544.GA17245@kroah.com> References: <95d618c692c8c501adf321cc416234b47e17ca41.1516386028.git.shreeya.patel23498@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <95d618c692c8c501adf321cc416234b47e17ca41.1516386028.git.shreeya.patel23498@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Sat, Jan 20, 2018 at 12:10:55AM +0530, Shreeya Patel wrote: > Change names of some variables and functions to conform > to the kernel coding style. The changes include some removal > of CamelCase warnings and renaming the variable and field names > that encode their type (eg the pointers seem to start with p). > > Signed-off-by: Shreeya Patel > --- > > Changes in v3 > -Edit the commit message. > > drivers/staging/rtl8723bs/hal/sdio_ops.c | 714 +++++++++++++++---------------- > 1 file changed, 357 insertions(+), 357 deletions(-) Please always test-build your patches so you don't get grumpy emails from kernel maintainers saying your patch breaks the build :( This give me the following error when applied: ERROR: "DisableInterrupt8723BSdio" [drivers/staging/rtl8723bs/r8723bs.ko] undefined! ERROR: "EnableInterrupt8723BSdio" [drivers/staging/rtl8723bs/r8723bs.ko] undefined! ERROR: "InitInterrupt8723BSdio" [drivers/staging/rtl8723bs/r8723bs.ko] undefined! ERROR: "InitSysInterrupt8723BSdio" [drivers/staging/rtl8723bs/r8723bs.ko] undefined! Please fix up and resend. greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel