From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752103AbeAWOks (ORCPT <rfc822;w@1wt.eu>);
        Tue, 23 Jan 2018 09:40:48 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59584 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751967AbeAWOkq (ORCPT <rfc822;Linux-kernel@vger.kernel.org>);
        Tue, 23 Jan 2018 09:40:46 -0500
Date: Tue, 23 Jan 2018 15:40:33 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: "Jin, Yao" <yao.jin@linux.intel.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>, jolsa@kernel.org,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
        kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH] perf util: Use target->per_thread and
 target->system_wide flags
Message-ID: <20180123144033.GA24739@krava>
References: <1516659340-30289-1-git-send-email-yao.jin@linux.intel.com>
 <CANLsYkwdHYMoHz8sbnKOOmGmE3CkZD1SRmDbnjJ0CbdoL7mdHw@mail.gmail.com>
 <06929c28-6431-29f2-340e-6dbc2302c78b@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <06929c28-6431-29f2-340e-6dbc2302c78b@linux.intel.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 23, 2018 at 07:02:44AM +0800, Jin, Yao wrote:

SNIP

> > >          threads = thread_map__new_str(target->pid, target->tid, target->uid,
> > > -                                     target->per_thread);
> > > +                                     target->per_thread && target->system_wide);
> > 
> > At first glance I thought your solution would do the trick but perf
> > record does use target->system_wide when the '-a' switch is used.
> > Moreover specifying the '-a' switch doesn't prevent the '--per-thread'
> > option from being used as well, making both target->perf_thread and
> > target_system_wide equal to true (and that is not good).
> > 
> > Although not a fan of adding more to struct target, the advantage of
> > having target->all_threads is that we are guaranteed that it isn't
> > used anywhere else.
> > 
> > Let me know what you think,
> > Mathieu
> > 
> 
> If we specify both '-a' and '--per-thread' to perf record, perf record will
> override'--per-thread'. So now target->per_thread = false, and
> target->system_wide = true.
> 
> If we specify '--per-thread' only to perf record, target->per_thread = true,
> and target->system_wide = false.
> 
> So whatever for any case, target->per_thread && target->system_wide is
> false.
> 
> Since the parameter is false, in thread_map__new_str(), it will not execute
> the thread_map__new_all_cpus(). So that will not change perf record previous
> behavior.
> 
> In perf stat, it allows the case that target->per_thread and
> target->system_wide are all true. That means we want to collect system-wide
> per-thread metrics.

could you please put this description into comment
before the thread_map__new_str is called?

thanks,
jirka