From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752301AbeAWShi (ORCPT ); Tue, 23 Jan 2018 13:37:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:43052 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752252AbeAWShg (ORCPT ); Tue, 23 Jan 2018 13:37:36 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0CFF2178C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Message-Id: <20180123183216.191160315@goodmis.org> User-Agent: quilt/0.63-1 Date: Tue, 23 Jan 2018 13:32:16 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Ingo Molnar , Andrew Morton , Thomas Gleixner , "H. Peter Anvin" , Nikolay Borisov , Josh Poimboeuf Subject: [PATCH 0/3] ftrace, orc, x86, tracing: Fix stack traces again Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With the new ORC unwinder, ftrace stack tracing became disfunctional. One was that ORC didn't know how to handle the ftrace callbacks in general (which Josh fixed). The other was that ORC would just bail if it hit a dynamically allocated trampoline. I added a check to the ORC unwinder to see if the trampoline belonged to ftrace, and if it did, use the orc entry of the static trampoline that was used to create the dynamic one (it would be identical). Finally, I noticed that the skip values of the stack tracing is out of whack. I went through and fixed them. Anyone have any issues with these patches? I'm starting my tests on them now and if all goes well, I plan on pushing them to Linus hopefully tonight. Thanks! -- Steve Josh Poimboeuf (1): x86/ftrace: Fix ORC unwinding from ftrace handlers Steven Rostedt (VMware) (2): ftrace, orc, x86: Handle ftrace dynamically allocated trampolines tracing: Update stack trace skipping for ORC unwinder ---- arch/x86/kernel/Makefile | 5 +++- arch/x86/kernel/ftrace_64.S | 24 +++++++++++------- arch/x86/kernel/unwind_orc.c | 48 +++++++++++++++++++++++++++++++++++- include/linux/ftrace.h | 2 ++ kernel/trace/ftrace.c | 26 +++++++++++--------- kernel/trace/trace.c | 34 ++++++++++++++----------- kernel/trace/trace_events_trigger.c | 13 ++++++++-- kernel/trace/trace_functions.c | 49 +++++++++++++++++++++++++++---------- 8 files changed, 150 insertions(+), 51 deletions(-)